Fix demo login seeded admin password#4367
Open
thefatcode wants to merge 3 commits intoopensourcepos:masterfrom
Open
Fix demo login seeded admin password#4367thefatcode wants to merge 3 commits intoopensourcepos:masterfrom
thefatcode wants to merge 3 commits intoopensourcepos:masterfrom
Conversation
- Update ospos_employees seed hash so admin/pointofsale works - Add PHPUnit guard test to prevent future regressions (issue opensourcepos#4365)
Member
|
hi @thefatcode thanks for the PR and nice find. The fact that the password in tables.sql does not match the hashed version might be expected. There is a migration script that should update it to the correct bcrypt hash. The issue is that currently demo server does not run latest master yet, a fix was done that prevents the password change and once 3.4.2 is officially out, the lockout issue should stop occuring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4365.
The seeded admin user in the DB init SQL had a bcrypt hash that no longer matched the documented demo credentials (
admin/pointofsale). This caused the public demo login to fail.Changes:
admin/pointofsaleworks again.pointofsale.Files:
Test: