Refactor reward tracking variables to camelCase#4366
Open
thefatcode wants to merge 2 commits intoopensourcepos:masterfrom
Open
Refactor reward tracking variables to camelCase#4366thefatcode wants to merge 2 commits intoopensourcepos:masterfrom
thefatcode wants to merge 2 commits intoopensourcepos:masterfrom
Conversation
objecttothis
requested changes
Jan 18, 2026
| /** | ||
| * Determines if the payment type represents a rewards payment across locales. | ||
| */ | ||
| private function is_reward_payment(string $payment_type): bool |
Member
There was a problem hiding this comment.
This function name and all calls need to be refactored still to camelCase
| /** | ||
| * Returns unique localized labels for the rewards payment type. | ||
| */ | ||
| private function get_reward_payment_labels(): array |
Member
|
Just these two functions and their calls that need to be refactored then we should be good to merge. |
Member
|
@objecttothis might be out of scope but extracting rewards specific logic to its own helper would make the code a bit cleaner |
Member
|
I agree. If @thefatcode doesn't want to do it then we should create an issue.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$sale_data) unchanged while refactoring local variables used in reward calculations and logging.update()anddelete()inapp/Models/Sale.php.