Skip to content

OCPBUGS-65634: add service account to verify pod #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ehearne-redhat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-65634: add service account to verify pod #638

ehearne-redhat wants to merge 1 commit into from
+36 −3

Conversation

@ehearne-redhat
Copy link
Contributor

@ehearne-redhat ehearne-redhat commented Feb 10, 2026

This PR addresses the revert that occurred in #609 . It includes test logic that ensures the job is deleted first before proceeding to delete the service account, assuming DeferCleanup uses LIFO.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 10, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2026

@ehearne-redhat: This pull request references Jira Issue OCPBUGS-65634, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR addresses the revert that occurred in #609 . It includes test logic that ensures the job is deleted first before proceeding to delete the service account, assuming DeferCleanup uses LIFO.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehearne-redhat
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ehearne-redhat ehearne-redhat force-pushed the add-service-account-curl-job-1 branch from d39797b to 7f4c112 Compare February 10, 2026 15:14
@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Feb 11, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2026

@ehearne-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ehearne-redhat
Copy link
Contributor Author

ehearne-redhat commented Feb 11, 2026

@oceanc80 after shift week, could you take a look? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

@bentito bentito Awaiting requested review from bentito

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

No one assigned

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ehearne-redhat @openshift-ci-robot