-
Notifications
You must be signed in to change notification settings - Fork 43
OCPQE-31553:adjust qe sa and permission test cases per new change #631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@kuiwang02: This pull request references OCPQE-31553 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kuiwang02 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
it is better to wait PR cluster-olm repo 163 to be merged and go into payload together. |
|
/payload-job periodic-ci-openshift-operator-framework-operator-controller-release-4.22-periodics-e2e-aws-ovn-upi-extended-f2 |
|
@kuiwang02: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0099f4a0-0268-11f1-9cbe-1d1d9e4a5ae8-0 |
9e7e4e8 to
b386507
Compare
… from boxcutterruntime
|
/test openshift-e2e-aws |
|
/test okd-scos-images |
1 similar comment
|
/test okd-scos-images |
|
@kuiwang02: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @jianzhangbjz @Xia-Zhao-rh @bandrade
Summary
This PR adjusts OLM v1 qe SA and preflight permission test cases per new change from boxcutterruntime, ensuring compatibility across all 4 environment combinations.
Besides them, it also enhance Makefile for
make verifyto report error and changefmttarget from auto-fix to report error and provide how to fix. Or else, if the case owner forget to make correct format,tests-extensionwill not report error and pass the job. For example olmv1-singleownnamespace.go has format error and thetests-extensionjob of the PR which submit the code does not report error, but actualy the code is not good format. here, we enhance Makefile and correct it.Environment Coverage
assisted-by: Claude Code