OCPBUGS-6945: Fixes node OS detection #3529

cheesesashimi · 2023-02-01T21:03:25Z

- What I did

The OS release node detection was not correctly detecting RHCOS 9 OSes due to the VERSION_ID field being populated with the OCP version instead of the OS version.

- How to verify it

Run the unit test suite.
Deploy an OCP cluster running either RHCOS 8 or RHCOS 9 (for RHCOS 9, provision a cluster using ClusterBot pointed at Switch to rhel-coreos-9 #3485).
Run the e2e test suite. The e2e test will output additional log entries indicating the node OS and, in the case of RHCOS 8 or 9, the version it is running, which should match the RHEL_VERSION field in the /etc/os-release / /usr/lib/os-release files on the node.

These logs will resemble:

go test -v -count=1 -run="TestOSDetection" .
=== RUN   TestOSDetection
=== RUN   TestOSDetection/#00
=== PAUSE TestOSDetection/#00
=== RUN   TestOSDetection/#01
=== PAUSE TestOSDetection/#01
=== RUN   TestOSDetection/#02
=== PAUSE TestOSDetection/#02
=== RUN   TestOSDetection/#03
=== PAUSE TestOSDetection/#03
=== RUN   TestOSDetection/#04
=== PAUSE TestOSDetection/#04
=== RUN   TestOSDetection/#05
=== PAUSE TestOSDetection/#05
=== CONT  TestOSDetection/#00
=== CONT  TestOSDetection/#03
=== CONT  TestOSDetection/#02
=== CONT  TestOSDetection/#04
=== CONT  TestOSDetection/#01
=== CONT  TestOSDetection/#05
    mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-173-134.ec2.internal with version 8.6
=== CONT  TestOSDetection/#04
    mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-163-214.ec2.internal with version 8.6
=== CONT  TestOSDetection/#01
    mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-138-110.ec2.internal with version 8.6
=== CONT  TestOSDetection/#00
    mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-134-197.ec2.internal with version 8.6
=== CONT  TestOSDetection/#02
    mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-147-135.ec2.internal with version 8.6
=== CONT  TestOSDetection/#03
    mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-152-25.ec2.internal with version 8.6
--- PASS: TestOSDetection (0.08s)
    --- PASS: TestOSDetection/#05 (0.67s)
    --- PASS: TestOSDetection/#04 (0.67s)
    --- PASS: TestOSDetection/#01 (0.70s)
    --- PASS: TestOSDetection/#00 (0.73s)
    --- PASS: TestOSDetection/#02 (0.74s)
    --- PASS: TestOSDetection/#03 (0.83s)
PASS
ok      github.com/openshift/machine-config-operator/test/e2e   1.566s

- Description for the changelog
Fixes node OS detection

openshift-ci · 2023-02-01T21:03:35Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

cgwalters · 2023-02-01T21:12:35Z

/approve
/lgtm
Looks sane to me, though I'd say I think at some point we should do feature detection (e.g. rpm -q openssh) - that way it'd work automatically on Alma Linux too etc.

cheesesashimi · 2023-02-01T21:34:16Z

Agreed about the feature detection. I guess the big TODO there is determining which features we need and understanding how to determine whether those features are there (e.g., rpm -q openssh, rpm-ostree version, etc.).

openshift-ci-robot · 2023-02-01T21:34:48Z

@cheesesashimi: This pull request references Jira Issue OCPBUGS-6945, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

The OS release node detection was not correctly detecting RHCOS 9 OSes due to the VERSION_ID field being populated with the OCP version instead of the OS version.

- How to verify it

Deploy an OCP cluster running RHCOS 9.

Run the e2e test suite.

Run the unit test suite.

- Description for the changelog
Fixes node OS detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-01T21:39:36Z

@cheesesashimi: This pull request references Jira Issue OCPBUGS-6945, which is invalid:

expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

- What I did

The OS release node detection was not correctly detecting RHCOS 9 OSes due to the VERSION_ID field being populated with the OCP version instead of the OS version.

- How to verify it

Run the unit test suite.
Deploy an OCP cluster running RHCOS 9 (e.g., provision a cluster using ClusterBot pointed at Switch to rhel-coreos-9 #3485).
Run the e2e test suite. Depending on the underlying node OS, there will be additional entries in the MCO e2e test output log.

These logs will resemble:

go test -v -count=1 -run="TestOSDetection" .
=== RUN   TestOSDetection
=== RUN   TestOSDetection/#00
=== PAUSE TestOSDetection/#00
=== RUN   TestOSDetection/#01
=== PAUSE TestOSDetection/#01
=== RUN   TestOSDetection/#02
=== PAUSE TestOSDetection/#02
=== RUN   TestOSDetection/#03
=== PAUSE TestOSDetection/#03
=== RUN   TestOSDetection/#04
=== PAUSE TestOSDetection/#04
=== RUN   TestOSDetection/#05
=== PAUSE TestOSDetection/#05
=== CONT  TestOSDetection/#00
=== CONT  TestOSDetection/#03
=== CONT  TestOSDetection/#02
=== CONT  TestOSDetection/#04
=== CONT  TestOSDetection/#01
=== CONT  TestOSDetection/#05
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-173-134.ec2.internal with version 8.6
=== CONT  TestOSDetection/#04
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-163-214.ec2.internal with version 8.6
=== CONT  TestOSDetection/#01
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-138-110.ec2.internal with version 8.6
=== CONT  TestOSDetection/#00
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-134-197.ec2.internal with version 8.6
=== CONT  TestOSDetection/#02
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-147-135.ec2.internal with version 8.6
=== CONT  TestOSDetection/#03
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-152-25.ec2.internal with version 8.6
--- PASS: TestOSDetection (0.08s)
   --- PASS: TestOSDetection/#05 (0.67s)
   --- PASS: TestOSDetection/#04 (0.67s)
   --- PASS: TestOSDetection/#01 (0.70s)
   --- PASS: TestOSDetection/#00 (0.73s)
   --- PASS: TestOSDetection/#02 (0.74s)
   --- PASS: TestOSDetection/#03 (0.83s)
PASS
ok      github.com/openshift/machine-config-operator/test/e2e   1.566s

- Description for the changelog
Fixes node OS detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cheesesashimi · 2023-02-01T22:10:44Z

/refresh jira

Also repackages osrelease so it can be reused in e2e

cheesesashimi · 2023-02-01T22:59:44Z

Now that I've fixed a few issues with the unit tests, I'd like both @cgwalters and @LorbusChris to weigh in on this PR.

cheesesashimi · 2023-02-01T22:59:53Z

/jira refresh

openshift-ci-robot · 2023-02-01T22:59:59Z

@cheesesashimi: This pull request references Jira Issue OCPBUGS-6945, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-02-01T23:38:51Z

@cheesesashimi: This pull request references Jira Issue OCPBUGS-6945, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

Details

In response to this:

- What I did

The OS release node detection was not correctly detecting RHCOS 9 OSes due to the VERSION_ID field being populated with the OCP version instead of the OS version.

- How to verify it

Run the unit test suite.
Deploy an OCP cluster running either RHCOS 8 or RHCOS 9 (for RHCOS 9, provision a cluster using ClusterBot pointed at Switch to rhel-coreos-9 #3485).
Run the e2e test suite. The e2e test will output additional log entries indicating the node OS and, in the case of RHCOS 8 or 9, the version it is running, which should match the RHEL_VERSION field in the /etc/os-release / /usr/lib/os-release files on the node.

These logs will resemble:

go test -v -count=1 -run="TestOSDetection" .
=== RUN   TestOSDetection
=== RUN   TestOSDetection/#00
=== PAUSE TestOSDetection/#00
=== RUN   TestOSDetection/#01
=== PAUSE TestOSDetection/#01
=== RUN   TestOSDetection/#02
=== PAUSE TestOSDetection/#02
=== RUN   TestOSDetection/#03
=== PAUSE TestOSDetection/#03
=== RUN   TestOSDetection/#04
=== PAUSE TestOSDetection/#04
=== RUN   TestOSDetection/#05
=== PAUSE TestOSDetection/#05
=== CONT  TestOSDetection/#00
=== CONT  TestOSDetection/#03
=== CONT  TestOSDetection/#02
=== CONT  TestOSDetection/#04
=== CONT  TestOSDetection/#01
=== CONT  TestOSDetection/#05
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-173-134.ec2.internal with version 8.6
=== CONT  TestOSDetection/#04
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-163-214.ec2.internal with version 8.6
=== CONT  TestOSDetection/#01
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-138-110.ec2.internal with version 8.6
=== CONT  TestOSDetection/#00
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-134-197.ec2.internal with version 8.6
=== CONT  TestOSDetection/#02
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-147-135.ec2.internal with version 8.6
=== CONT  TestOSDetection/#03
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-152-25.ec2.internal with version 8.6
--- PASS: TestOSDetection (0.08s)
   --- PASS: TestOSDetection/#05 (0.67s)
   --- PASS: TestOSDetection/#04 (0.67s)
   --- PASS: TestOSDetection/#01 (0.70s)
   --- PASS: TestOSDetection/#00 (0.73s)
   --- PASS: TestOSDetection/#02 (0.74s)
   --- PASS: TestOSDetection/#03 (0.83s)
PASS
ok      github.com/openshift/machine-config-operator/test/e2e   1.566s

- Description for the changelog
Fixes node OS detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-02-02T02:11:58Z

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`987f0a1`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	`987f0a1`	link	false	`/test okd-scos-e2e-gcp-ovn-upgrade`
ci/prow/e2e-gcp-rt-op	`987f0a1`	link	false	`/test e2e-gcp-rt-op`
ci/prow/e2e-hypershift	`987f0a1`	link	false	`/test e2e-hypershift`
ci/prow/e2e-alibabacloud-ovn	`987f0a1`	link	false	`/test e2e-alibabacloud-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rioliu-rh · 2023-02-02T02:51:15Z

/hold
/cc @sergiordlr

openshift-ci · 2023-02-02T02:51:21Z

@rioliu-rh: GitHub didn't allow me to request PR reviews from the following users: for, qe, testing.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/hold
/cc @sergiordlr for qe testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rioliu-rh · 2023-02-02T07:25:05Z

setup cluster via clusterbot+Switch to rhel-coreos-9 #3485
check os-release file content on worker node

 oc debug node/ip-10-0-139-113.us-west-1.compute.internal -- chroot /host cat /etc/os-release
Temporary namespace openshift-debug-hgp9x is created for debugging node...
Starting pod/ip-10-0-139-113us-west-1computeinternal-debug ...
To use host binaries, run `chroot /host`
NAME="Red Hat Enterprise Linux CoreOS"
ID="rhcos"
ID_LIKE="rhel fedora"
VERSION="413.90.202212151724-0"
VERSION_ID="4.13"
VARIANT="CoreOS"
VARIANT_ID=coreos
PLATFORM_ID="platform:el9"
PRETTY_NAME="Red Hat Enterprise Linux CoreOS 413.90.202212151724-0 (Plow)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:9::coreos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://docs.openshift.com/container-platform/4.13/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="OpenShift Container Platform"
REDHAT_BUGZILLA_PRODUCT_VERSION="4.13"
REDHAT_SUPPORT_PRODUCT="OpenShift Container Platform"
REDHAT_SUPPORT_PRODUCT_VERSION="4.13"
OPENSHIFT_VERSION="4.13"
RHEL_VERSION="9.0"
OSTREE_VERSION="413.90.202212151724-0"

Removing debug pod ...
Temporary namespace openshift-debug-hgp9x was removed.

run unit test, test output is like below

go test -v -count=1 -run="TestOSDetection" .
=== RUN   TestOSDetection
=== RUN   TestOSDetection/#00
=== PAUSE TestOSDetection/#00
=== RUN   TestOSDetection/#01
=== PAUSE TestOSDetection/#01
=== RUN   TestOSDetection/#02
=== PAUSE TestOSDetection/#02
=== RUN   TestOSDetection/#03
=== PAUSE TestOSDetection/#03
=== RUN   TestOSDetection/#04
=== PAUSE TestOSDetection/#04
=== CONT  TestOSDetection/#00
=== CONT  TestOSDetection/#03
=== CONT  TestOSDetection/#04
=== CONT  TestOSDetection/#02
=== CONT  TestOSDetection/#01
=== CONT  TestOSDetection/#00
    node_os_test.go:68: Identified Red Hat Enterprise Linux CoreOS 9.0 on node ip-10-0-139-113.us-west-1.compute.internal
=== CONT  TestOSDetection/#01
    node_os_test.go:68: Identified Red Hat Enterprise Linux CoreOS 9.0 on node ip-10-0-154-69.us-west-1.compute.internal
=== CONT  TestOSDetection/#04
    node_os_test.go:68: Identified Red Hat Enterprise Linux CoreOS 9.0 on node ip-10-0-220-74.us-west-1.compute.internal
=== CONT  TestOSDetection/#03
    node_os_test.go:68: Identified Red Hat Enterprise Linux CoreOS 9.0 on node ip-10-0-183-67.us-west-1.compute.internal
=== CONT  TestOSDetection/#02
    node_os_test.go:68: Identified Red Hat Enterprise Linux CoreOS 9.0 on node ip-10-0-179-181.us-west-1.compute.internal
--- PASS: TestOSDetection (1.12s)
    --- PASS: TestOSDetection/#00 (20.86s)
    --- PASS: TestOSDetection/#01 (21.44s)
    --- PASS: TestOSDetection/#04 (21.47s)
    --- PASS: TestOSDetection/#03 (21.62s)
    --- PASS: TestOSDetection/#02 (22.63s)
PASS
ok  	github.com/openshift/machine-config-operator/test/e2e	25.005s

rioliu-rh · 2023-02-02T07:25:55Z

/unhold

rioliu-rh · 2023-02-02T07:32:22Z

/label qe-approved

rioliu-rh · 2023-02-02T07:36:49Z

@cheesesashimi @cgwalters verified with unit test, please confirm, thanks

cheesesashimi · 2023-02-02T15:46:38Z

This failure in e2e-aws-ovn is related to https://issues.redhat.com/browse/TRT-819. I am reasonably confident it was not caused by the changes in this PR.

cgwalters

/lgtm

cgwalters · 2023-02-03T15:10:25Z

pkg/daemon/osrelease/osrelease.go

+	"path/filepath"
+	"strings"
+
+	"github.com/ashcrow/osrelease"


This is fine as is, but perhaps it'd make sense at some point to have this functionality move into that upstream library. We could also move it to e.g. github.com/coreos/osrelease too for more shared maintenance.

Yeah, that would be nice. I have a few ideas around some additional things we could port there such as handling paths, etc.

openshift-ci · 2023-02-03T15:11:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters,cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-02-03T15:41:03Z

/retest-required

Remaining retests: 0 against base HEAD 46ecd47 and 2 for PR HEAD 987f0a1 in total

openshift-ci-robot · 2023-02-03T20:51:02Z

@cheesesashimi: All pull requests linked via external trackers have merged:

openshift/machine-config-operator#3529

Jira Issue OCPBUGS-6945 has been moved to the MODIFIED state.

Details

In response to this:

- What I did

The OS release node detection was not correctly detecting RHCOS 9 OSes due to the VERSION_ID field being populated with the OCP version instead of the OS version.

- How to verify it

Run the unit test suite.
Deploy an OCP cluster running either RHCOS 8 or RHCOS 9 (for RHCOS 9, provision a cluster using ClusterBot pointed at Switch to rhel-coreos-9 #3485).
Run the e2e test suite. The e2e test will output additional log entries indicating the node OS and, in the case of RHCOS 8 or 9, the version it is running, which should match the RHEL_VERSION field in the /etc/os-release / /usr/lib/os-release files on the node.

These logs will resemble:

go test -v -count=1 -run="TestOSDetection" .
=== RUN   TestOSDetection
=== RUN   TestOSDetection/#00
=== PAUSE TestOSDetection/#00
=== RUN   TestOSDetection/#01
=== PAUSE TestOSDetection/#01
=== RUN   TestOSDetection/#02
=== PAUSE TestOSDetection/#02
=== RUN   TestOSDetection/#03
=== PAUSE TestOSDetection/#03
=== RUN   TestOSDetection/#04
=== PAUSE TestOSDetection/#04
=== RUN   TestOSDetection/#05
=== PAUSE TestOSDetection/#05
=== CONT  TestOSDetection/#00
=== CONT  TestOSDetection/#03
=== CONT  TestOSDetection/#02
=== CONT  TestOSDetection/#04
=== CONT  TestOSDetection/#01
=== CONT  TestOSDetection/#05
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-173-134.ec2.internal with version 8.6
=== CONT  TestOSDetection/#04
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-163-214.ec2.internal with version 8.6
=== CONT  TestOSDetection/#01
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-138-110.ec2.internal with version 8.6
=== CONT  TestOSDetection/#00
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-134-197.ec2.internal with version 8.6
=== CONT  TestOSDetection/#02
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-147-135.ec2.internal with version 8.6
=== CONT  TestOSDetection/#03
   mcd_test.go:55: Identified OS "Red Hat Enterprise Linux CoreOS" on node ip-10-0-152-25.ec2.internal with version 8.6
--- PASS: TestOSDetection (0.08s)
   --- PASS: TestOSDetection/#05 (0.67s)
   --- PASS: TestOSDetection/#04 (0.67s)
   --- PASS: TestOSDetection/#01 (0.70s)
   --- PASS: TestOSDetection/#00 (0.73s)
   --- PASS: TestOSDetection/#02 (0.74s)
   --- PASS: TestOSDetection/#03 (0.83s)
PASS
ok      github.com/openshift/machine-config-operator/test/e2e   1.566s

- Description for the changelog
Fixes node OS detection

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023

openshift-ci bot assigned cgwalters Feb 1, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023

cheesesashimi changed the title ~~fixes node OS detection~~ OCPBUGS-6945: Fixes node OS detection Feb 1, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 1, 2023

cheesesashimi force-pushed the zzlotnik/OCPBUGS-6945 branch from 98180c2 to 3d1c782 Compare February 1, 2023 22:09

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023

cheesesashimi marked this pull request as ready for review February 1, 2023 22:10

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023

openshift-ci bot requested review from cgwalters and jkyros February 1, 2023 22:14

cheesesashimi force-pushed the zzlotnik/OCPBUGS-6945 branch from 3d1c782 to 349a138 Compare February 1, 2023 22:28

revises node OS version detection logic

659b55b

Also repackages osrelease so it can be reused in e2e

cheesesashimi force-pushed the zzlotnik/OCPBUGS-6945 branch 2 times, most recently from 2d0693e to 5aa8f26 Compare February 1, 2023 22:52

openshift-ci bot requested a review from rioliu-rh February 1, 2023 23:00

verifies node OS in e2e test

987f0a1

cheesesashimi force-pushed the zzlotnik/OCPBUGS-6945 branch from 5aa8f26 to 987f0a1 Compare February 1, 2023 23:06

openshift-ci bot requested a review from sergiordlr February 2, 2023 02:51

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 2, 2023

cheesesashimi mentioned this pull request Feb 2, 2023

MCO-116: Ensures that SSH keys are in the right place on RHCOS 9 #3534

Closed

cgwalters approved these changes Feb 3, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023

openshift-merge-robot merged commit 944855d into openshift:master Feb 3, 2023

cheesesashimi deleted the zzlotnik/OCPBUGS-6945 branch March 21, 2024 14:03

OCPBUGS-6945: Fixes node OS detection #3529

OCPBUGS-6945: Fixes node OS detection #3529

Uh oh!

Conversation

cheesesashimi commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 1, 2023

Uh oh!

cgwalters commented Feb 1, 2023

Uh oh!

cheesesashimi commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

cheesesashimi commented Feb 1, 2023

Uh oh!

cheesesashimi commented Feb 1, 2023

Uh oh!

cheesesashimi commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

openshift-ci-robot commented Feb 1, 2023

Uh oh!

openshift-ci bot commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rioliu-rh commented Feb 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 2, 2023

Uh oh!

rioliu-rh commented Feb 2, 2023

Uh oh!

rioliu-rh commented Feb 2, 2023

Uh oh!

rioliu-rh commented Feb 2, 2023

Uh oh!

rioliu-rh commented Feb 2, 2023

Uh oh!

cheesesashimi commented Feb 2, 2023

Uh oh!

cgwalters left a comment

Choose a reason for hiding this comment

Uh oh!

cgwalters Feb 3, 2023

Choose a reason for hiding this comment

Uh oh!

cheesesashimi Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 3, 2023

Uh oh!

openshift-ci-robot commented Feb 3, 2023

Uh oh!

openshift-ci-robot commented Feb 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cheesesashimi commented Feb 1, 2023 •

edited

Loading

openshift-ci bot commented Feb 2, 2023 •

edited

Loading

rioliu-rh commented Feb 2, 2023 •

edited

Loading