Skip to content

Conversation

@cheesesashimi
Copy link
Member

- What I did

Preemptively detect if the initial cluster config has a realtime kernel enabled, then skip the RT kernel test if so.

- How to verify it

Run the test on a kernel preemptively configured with a realtime kernel and verify that the TestKernelType test is skipped

- Description for the changelog
Skip kernel type test on RT kernels

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2023

@cheesesashimi: This pull request references [Jira Issue MCO-458](https://issues.redhat.com//browse/MCO-458), which is a valid jira issue.

Details

In response to this:

- What I did

Preemptively detect if the initial cluster config has a realtime kernel enabled, then skip the RT kernel test if so.

- How to verify it

Run the test on a kernel preemptively configured with a realtime kernel and verify that the TestKernelType test is skipped

- Description for the changelog
Skip kernel type test on RT kernels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@yuqi-zhang
Copy link
Contributor

lgtm, should this pass the new tests?
/test e2e-gcp-rt-op

Hopefully that was the right test to run

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2023

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6550598 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 6550598 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-rt-op 6550598 link false /test e2e-gcp-rt-op
ci/prow/e2e-alibabacloud-ovn 6550598 link false /test e2e-alibabacloud-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cheesesashimi
Copy link
Member Author

@yuqi-zhang The e2e-gcp-rt-op tests are currently failing for unrelated reasons. After doing some investigation, I think we may want to hold off on merging this PR for right now.

@cheesesashimi cheesesashimi deleted the zzlotnik/skip-rt-kernel-test branch March 21, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants