-
Notifications
You must be signed in to change notification settings - Fork 632
Clarify in tutorial that the native UBI plugin is NOT available in Amazon Managed Service. #11622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify in tutorial that the native UBI plugin is NOT available in Amazon Managed Service. #11622
Conversation
… Service Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
martin-gaievski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you
kolchfa-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @epugh! A couple of suggestions before moving on to editorial review.
Improved language. Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
|
Thank you @kolchfa-aws, I accepted the changes, they looked great! |
natebower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epugh Please see my changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
|
Thanks @natebower for your wordsmithing. I accepted the changes and this PR is ready for merging! |
natebower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…azon Managed Service. (#11622) * Clarify that the native UBI plugin is not available on Amazon Managed Service Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> * Use a strong warning formatting for the call out Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> * Apply suggestions from code review Improved language. Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> --------- Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 5ba4577) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Description
Updates the tutorial to clarify that it shows you how to index UBI formatted data without the use of the native UBI plugin, as that is not available.
Issues Resolved
Closes #11518
Version
2.19 and on.
Frontend features
n/a
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.