Allow 16 digit precision #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@lordnynex Will you mind adding a test case to the existing test suite for this? Thanks! |
Member
Author
|
@agentzh The tests dir is a little confusing. I added the tests to agentzh.t. Please tell me if this is not the right place. |
Member
|
@lordnynex Yeah, I know |
agentzh
pushed a commit
that referenced
this pull request
Nov 4, 2015
thanks lordnynex for the patch in #4. Test cases for changing precision
agentzh
pushed a commit
that referenced
this pull request
Nov 4, 2015
thanks lordnynex for the patch in #4. Test cases for changing precision
Member
|
@lordnynex I've applied a slightly modified version of your patch (which fixed a failure in the old test suite). Thanks a lot! |
agentzh
pushed a commit
that referenced
this pull request
Nov 4, 2015
… via cjson.encode_number_precision(). thanks lordnynex for the patch in #4. Test cases for changing precision
hishamhm
pushed a commit
to hishamhm/lua-cjson
that referenced
this pull request
Jul 12, 2022
Add support compiled to libcjson.a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change maximum allowable precision for encode_number_precision from 14 to 16.
I am experiencing a bug in my application where some client generated sequence numbers are being stored incorrectly due to a loss of precision. As far as I understand, a double has a maximum of 16 decimal places. This module only allows 14.