ContentManager Enhancement: show more info for consists #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the weigh bar-graph, line-wrapping hinders readability. Also corrected incorrect widths in left panel.
rwf-rr
commented
Apr 21, 2024
rwf-rr
commented
Apr 21, 2024
twpol
requested changes
Apr 25, 2024
Member
twpol
left a comment
twpol
left a comment
There was a problem hiding this comment.
This is a very solid set of changes and – even though I am surprised that people are interested in the contributed Content Manager project – I am happy for it to go in.
There are just a few minor things I'd like changed, which are hopefully easy.
Pull in recent changes from upstream (openrails).
twpol
approved these changes
Jan 3, 2025
Member
twpol
left a comment
twpol
left a comment
There was a problem hiding this comment.
Thanks very much for the updates and apologies for the time it has taken me to get back and review this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ContentManager, show additional properties for consists, such as: engine and car counts, total length, total weight, horsepower-per-ton, tons-per-operative-brake, etc. The latter two are North America specific - I don't know if there are equivalents for pther parts of the world.
Update Nov 2024
Details
The most significant change is that the consist view now has to read and parse each car (.wag or .eng file). The search function is negatively impacted, taking about 40% longer (in my case 2:40 min vs 2 min).
The units are based on the ORTS options. Since the ContentManager does not have a route context for consists, the system units are used in that case.
Impacted files that are not ContentManager specific:
Tested on: Train Simulations Scenic, Mullan Pass and Selgman packages; base MSTS packages; some Swiss packages.
Consist
The additional properties. HPT and TPOB are shown only when US Imperial units are used.
Also added a bar-graph to the consist, so that loads and empties are identifyable. Each asterisk represents 20 metric tons.
Cars
Since some of the above fields are aggregated, they might as well be shown for cars.
Engines:
Wagons:
Other
Disabled word-wrapping in the Text box, in favour of horizontal scrolling. The bar-graph is not very readable with line-wraps.