fix: Refined comment summarising property SData1 #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in Launchpad.net/or/+bug/2038756
twpol
pushed a commit
that referenced
this pull request
Oct 9, 2023
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #865 at 776d6df: Dispatcher window improvements - Pull request #874 at f8dbeab: Dynamic brake controller refactoring - Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #878 at 90b5712: Implement Polach Adhesion - Pull request #879 at 5a0ff7b: chore: remove Website folder - Pull request #880 at 084b404: fix: Refined comment summarising property SData1
twpol
pushed a commit
that referenced
this pull request
Oct 10, 2023
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #865 at 776d6df: Dispatcher window improvements - Pull request #874 at f8dbeab: Dynamic brake controller refactoring - Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #878 at bb3dfb9: Implement Polach Adhesion - Pull request #879 at 5a0ff7b: chore: remove Website folder - Pull request #880 at 084b404: fix: Refined comment summarising property SData1
twpol
pushed a commit
that referenced
this pull request
Oct 10, 2023
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #865 at 776d6df: Dispatcher window improvements - Pull request #874 at f8dbeab: Dynamic brake controller refactoring - Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #878 at 9407233: Implement Polach Adhesion - Pull request #879 at 5a0ff7b: chore: remove Website folder - Pull request #880 at 084b404: fix: Refined comment summarising property SData1
twpol
pushed a commit
that referenced
this pull request
Oct 14, 2023
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #865 at 776d6df: Dispatcher window improvements - Pull request #874 at f8dbeab: Dynamic brake controller refactoring - Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #878 at ef944ab: Implement Polach Adhesion - Pull request #879 at 5a0ff7b: chore: remove Website folder - Pull request #880 at 084b404: fix: Refined comment summarising property SData1
twpol
pushed a commit
that referenced
this pull request
Oct 14, 2023
- Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #874 at f8dbeab: Dynamic brake controller refactoring - Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #878 at ef944ab: Implement Polach Adhesion - Pull request #879 at 5a0ff7b: chore: remove Website folder - Pull request #880 at 084b404: fix: Refined comment summarising property SData1
Csantucci
approved these changes
Oct 15, 2023
Contributor
Csantucci
left a comment
Csantucci
left a comment
There was a problem hiding this comment.
That's OK to me, thanks.
twpol
pushed a commit
that referenced
this pull request
Oct 15, 2023
- Pull request #570 at c59c788: Experimental glTF 2.0 support with PBR lighting - Pull request #839 at d00beb9: First phase of https://blueprints.launchpad.net/or/+spec/additional-cruise-control-parameters - Pull request #874 at f8dbeab: Dynamic brake controller refactoring - Pull request #875 at 43bf33e: Bug fix for https://bugs.launchpad.net/or/+bug/2036346 Player train switching doesn't work with 3D cabs - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #878 at ef944ab: Implement Polach Adhesion - Pull request #880 at 084b404: fix: Refined comment summarising property SData1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in Launchpad.net/or/+bug/2038756 by David Webb