Improve sky dome distortion causing bug #1471416 #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Jan 2, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1 - Pull request #759 at 5ab8faa: fix: Improve sky dome distortion causing bug #1471416
twpol
pushed a commit
that referenced
this pull request
Jan 2, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1 - Pull request #759 at 5ab8faa: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration
twpol
pushed a commit
that referenced
this pull request
Jan 2, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration
twpol
pushed a commit
that referenced
this pull request
Jan 3, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration
cjakeman
reviewed
Jan 3, 2023
Contributor
cjakeman
left a comment
cjakeman
left a comment
There was a problem hiding this comment.
Hi James,
Interesting to see how you have re-factored this with a new SkyInterpolation class and enums and applied our style standards.
I also spotted that you have corrected errors for calculation of fog colour and the wvp matrix, so this PR is quite an improvement.
In your forum post, you reviewed the scheme as:
Sky is formed of 3 layers (back to front):
Cloud-less sky and night sky textures, blended according to time of day, and with sun effect added in (in the shader)
Moon textures (phase is random currently)
Clouds blended by overcast factor and animated by wind speed and direction
Sky dome is 6000m away (but this doesn't matter since it is fixed to the camera and always drawn behind everything else)
Sky dome is split into 32 segments (sides) around the center
Sky dome is split into 16 segments (steps) from top to horizon and 1 more segment beyond horizon
Moon is 5700m away
Cloud dome is 5400m away
Would it be helpful to add that information into the comments?
Best wishes,
Chris
twpol
pushed a commit
that referenced
this pull request
Jan 3, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration
twpol
pushed a commit
that referenced
this pull request
Jan 3, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 1b56aa6: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration
twpol
pushed a commit
that referenced
this pull request
Jan 4, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 1b56aa6: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds
Member
Author
I have added the relevant parts to the comment for The specific radii have changed and are all in constants just above the comment, so I didn't feel the need to repeat them inside the comment |
twpol
pushed a commit
that referenced
this pull request
Jan 4, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 1b56aa6: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at 3c84439: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds
twpol
pushed a commit
that referenced
this pull request
Jan 5, 2023
- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at 3c84439: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds
cjakeman
approved these changes
Jan 5, 2023
Contributor
cjakeman
left a comment
cjakeman
left a comment
There was a problem hiding this comment.
Thanks for the extra comments, James.
Approved
twpol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.launchpad.net/or/+bug/1471416