Brake controller scripts refactoring and improvements for mouse control #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharpe49
added
enhancement
cesarBLG
reviewed
Oct 25, 2022
| public Action<float> SetDynamicBrakeIntervention; | ||
| protected void SetDynamicBrakeIntervention(float value) | ||
| { | ||
| // TODO: Set dynamic brake intervention instead of controller position |
Contributor
There was a problem hiding this comment.
I fixed this TODO some days ago, so if you had the idea of changing this you don't have to.
Contributor
Author
There was a problem hiding this comment.
Well, if you have a different code available for this, I can integrate it in this PR too.
Contributor
There was a problem hiding this comment.
The changes were introduced together with some changes to dynamic brake blending (see #732). Your PR seems harmless, so I think it's better to merge this first, and then I'll rebase #732.
This also conflicts with #713 (it adds a hook to command train brakes from cruise control), which is almost ready except for documentation.
cesarBLG
reviewed
Oct 26, 2022
Sharpe49
force-pushed
the
feature/brake-controller-improvements
branch
from
c541d55 to
1934409
Compare
cesarBLG
previously approved these changes
Oct 27, 2022
Contributor
Author
|
Thanks, waiting for blueprint validation. |
Contributor
Author
|
Blueprints have been approved... but I have to rebase. You will have to approve the changes once more. |
Sharpe49
force-pushed
the
feature/brake-controller-improvements
branch
from
1934409 to
ffe4bba
Compare
…rn as the C# signal scripts (compatible with current scripts)
…h scripted brake controller
Sharpe49
force-pushed
the
feature/brake-controller-improvements
branch
from
ffe4bba to
88cadc9
Compare
twpol
pushed a commit
that referenced
this pull request
Dec 11, 2022
- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #738 at 88cadc9: Brake controller scripts refactoring and improvements for mouse control - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 4609acb: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #755 at f79c1e2: Bug fix for https://bugs.launchpad.net/or/+bug/1999330 Crash with a throttle-air combined control - Pull request #756 at c3f5c55: Bug fix for https://bugs.launchpad.net/or/+bug/1999253 Night .dds textures not loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprints:
https://blueprints.launchpad.net/or/+spec/scripts-refactoring
https://blueprints.launchpad.net/or/+spec/brake-controller-scripts-improvements