fix: Log first error during Viewer mark-sweep clean-up #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Oct 24, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 0488826: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at 085d738: Improvements for air brakes
twpol
pushed a commit
that referenced
this pull request
Oct 24, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 0488826: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at 085d738: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly
Sharpe49
approved these changes
Oct 24, 2022
twpol
pushed a commit
that referenced
this pull request
Oct 24, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 0488826: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at 085d738: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists
twpol
pushed a commit
that referenced
this pull request
Oct 24, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at 085d738: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists
twpol
pushed a commit
that referenced
this pull request
Oct 24, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at ce99b03: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists
twpol
pushed a commit
that referenced
this pull request
Oct 25, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at ce99b03: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #737 at 96d12f1: Fixed brake controller script not being loaded in timetable mode
twpol
pushed a commit
that referenced
this pull request
Oct 25, 2022
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset) - Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #677 at c1c417f: Correct double heading bug - Pull request #706 at 265d33d: Extended door functionality - Pull request #713 at 65741c7: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at fd9e47a: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #731 at f1348a4: fix: Log first error during Viewer mark-sweep clean-up - Pull request #732 at efbc397: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #736 at a845085: Replaced truncated brake token table with lists - Pull request #737 at 96d12f1: Fixed brake controller script not being loaded in timetable mode
Sharpe49
added a commit
that referenced
this pull request
Oct 26, 2022
Merge pull request #731 from twpol/bugfix/multithread-crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this crash: http://www.elvastower.com/forums/index.php?/topic/36334-open-rails-15-is-coming-soon/page__view__findpost__p__287973
This will log a warning for the first exception during the Viewer's mark-sweep clean-up routine but will continue
Subsequent errors (whether the same or different) in this code will be silently ignored
Further investigation is needed into why this crash even occurs