Skip to content

Search for NORMAL signals if no argument is provided #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cesarBLG merged 3 commits into from
Oct 14, 2022
Merged

Search for NORMAL signals if no argument is provided #712

cesarBLG merged 3 commits into from
Oct 14, 2022

Conversation

@cesarBLG
Copy link
Contributor

@cesarBLG cesarBLG commented Sep 17, 2022

twpol pushed a commit that referenced this pull request Sep 17, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
ebe8ce6 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at 12d50c5: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #710 at 81ab87c: Fix GetDrawState when using upper characters in the name parameter
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 28372a4: Search for NORMAL signals if no argument is provided
twpol pushed a commit that referenced this pull request Sep 17, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
7fedb57 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at 12d50c5: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 28372a4: Search for NORMAL signals if no argument is provided
@Csantucci
Copy link
Contributor

Csantucci commented Sep 17, 2022

How did OR behave before the changes leading to crash were introduced? Did it default to NORMAL?

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 18, 2022

The default value for SIGSCR parameters is 0, which corresponded to the NORMAL signal type.

@Csantucci
Copy link
Contributor

Csantucci commented Sep 18, 2022

The default value for SIGSCR parameters is 0, which corresponded to the NORMAL signal type.

Then the fix is OK to me, and IMHO it should be introduced also in 1.5.

Csantucci
Csantucci previously approved these changes Sep 18, 2022
View reviewed changes
@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 18, 2022

The problem was introduced during the conversion of the signal function from enum to class in #537, which is not present in 1.5

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 18, 2022

There are more errors related to this, so converting this to draft until they are solved.

@cesarBLG cesarBLG marked this pull request as draft September 18, 2022 11:40
@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 18, 2022

@Sharpe49 It seems some scripts are really bad written, with usages like next_sig_lr() [no argument] or next_sig_lr(5) [number instead of SIGFN]. My fix should allow this kind of weird syntax, but it's not elegant. I think it would be better to restore the previous code, keeping a Dictionary<int, SignalFunction>.

Any suggestions?

twpol pushed a commit that referenced this pull request Sep 18, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
c4d99b9 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at 12d50c5: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 6cdbdfe: Search for NORMAL signals if no argument is provided
@Sharpe49
Copy link
Contributor

Sharpe49 commented Sep 19, 2022

How about assigning values to the elements of the Enum (0, 1, 2, etc.) in order for them to always have the same value.
Then, during conversion, check if the integer value exists in the Enum (with Enum.IsDefined), then cast the value to SignalFunction (or set default value if it is undefined).

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Sep 19, 2022 •
edited
Loading

The values are already assigned to a enum (namely the MstsSignalFunction enum). The problem is from the conversion from that enum to a SignalFunction. I wasn't sure if using

new SignalFunction((MstsSignalFunction)parameter_value);

was acceptable during the creation of the SCRParameter, due to the object allocation. I think it might be OK provided that SCRParameters are constructed during loading time and then never modified.

twpol pushed a commit that referenced this pull request Sep 20, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
1ab8e83 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at 12d50c5: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 9aa54c6: Search for NORMAL signals if no argument is provided
@cesarBLG cesarBLG marked this pull request as ready for review September 20, 2022 13:52
twpol pushed a commit that referenced this pull request Sep 20, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
a12ef16 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at 12d50c5: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
twpol pushed a commit that referenced this pull request Sep 22, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
d670965 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c0e78f2: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
twpol pushed a commit that referenced this pull request Sep 22, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
0a7b16a 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at ad0cd0e: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
twpol pushed a commit that referenced this pull request Sep 22, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
829dd77 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
twpol pushed a commit that referenced this pull request Sep 22, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
12c6f20 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 637f947: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 23, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
cd1393f 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 0b1f1e6: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 24, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
dae845b 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 80491f5: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 24, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
678a896 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 5d62da5: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 24, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
75de69f 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at dd69c72: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 25, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
fddda6c 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at e44897d: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 39fb6c2: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 26, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
f315d1c 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at 7b6b608: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 85ce248: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 39fb6c2: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 26, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 12 pull requests
07ba18d 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at 7b6b608: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #711 at 20f381f: Bug fix for https://bugs.launchpad.net/or/+bug/1989426 Out of bounds crash in Precipitation.cs
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 39fb6c2: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 26, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 11 pull requests
f10206e 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at 7b6b608: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 39fb6c2: https://blueprints.launchpad.net/or/+spec/cruise-control
twpol pushed a commit that referenced this pull request Sep 27, 2022
@openrails-bot
Automatic merge of T1.5-rc1-61-g82a9ca1ff and 13 pull requests
22fe973 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #688 at 7b6b608: adds Help Icons to Video tab
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 39fb6c2: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #714 at d289d28: Feature/1.5 merge fix 1
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
twpol pushed a commit that referenced this pull request Oct 2, 2022
@openrails-bot
Automatic merge of T1.5-rc1-65-g2dd1c6336 and 13 pull requests
9610f07 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 2478066: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #714 at d289d28: Feature/1.5 merge fix 1
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
twpol pushed a commit that referenced this pull request Oct 3, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 13 pull requests
f9f5472 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 2478066: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
twpol pushed a commit that referenced this pull request Oct 3, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 13 pull requests
118e04b 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 3f5e038: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
twpol pushed a commit that referenced this pull request Oct 3, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 14 pull requests
4062d23 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 3f5e038: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
twpol pushed a commit that referenced this pull request Oct 4, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 14 pull requests
3d87c67 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: TCS Extensions
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 33de10b: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
twpol pushed a commit that referenced this pull request Oct 7, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 14 pull requests
9ec0b81 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 8bb3bfe: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
twpol pushed a commit that referenced this pull request Oct 7, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 14 pull requests
5124ae2 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at ffc93eb: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
twpol pushed a commit that referenced this pull request Oct 7, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 14 pull requests
4fc497f 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at f281de6: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
twpol pushed a commit that referenced this pull request Oct 7, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 14 pull requests
afe0099 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #693 at 453ac3d: French locales
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 966a61c: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #716 at 23c491e: Bug fix for https://bugs.launchpad.net/or/+bug/1990553 Typo in GenericItem2 command
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
twpol pushed a commit that referenced this pull request Oct 8, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 13 pull requests
68a3e40 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 966a61c: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #721 at 0eec308: Do not trigger wheelslip alarm until some time passes
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #726 at b6cc020: Correctly initialize triple valve for EP trains
twpol pushed a commit that referenced this pull request Oct 8, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 12 pull requests
360e004 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 966a61c: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #726 at b6cc020: Correctly initialize triple valve for EP trains
twpol pushed a commit that referenced this pull request Oct 9, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 12 pull requests
c19faf8 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 6c8701f: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #726 at b6cc020: Correctly initialize triple valve for EP trains
twpol pushed a commit that referenced this pull request Oct 10, 2022
@openrails-bot
Automatic merge of T1.5-rc1-80-gf4212d3c4 and 12 pull requests
cd2b2c9 
- Pull request #570 at 824f96f: Experimental glTF 2.0 support with PBR lighting
- Pull request #630 at 704731a: Sky Color Fix (Addresses Trello Roadmap Card #367 for More accurate sunrise and sunset)
- Pull request #652 at 918fdb1: Add button functions to Raildriver
- Pull request #677 at c1c417f: Correct double heading bug
- Pull request #692 at 20de7da: Italian translation for OR 1.5
- Pull request #699 at 6baf43d: Bug fix for https://bugs.launchpad.net/or/+bug/1987453. Web: HUD/Force Information, some labels not visible.
- Pull request #706 at 265d33d: Extended door functionality
- Pull request #712 at 68cd8ab: Search for NORMAL signals if no argument is provided
- Pull request #713 at 6c8701f: https://blueprints.launchpad.net/or/+spec/cruise-control 
- Pull request #715 at 447143b: Bug fix for //bugs.launchpad.net/or/+bug/1990930 Default snow terrtex not appearing
- Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor
- Pull request #726 at d812554: Correctly initialize triple valve for EP trains
@cesarBLG cesarBLG added the bug Something isn't working label Oct 10, 2022
@cesarBLG cesarBLG merged commit 77be597 into openrails:master Oct 14, 2022
Csantucci added a commit to Csantucci/openrails that referenced this pull request Oct 16, 2022
@Csantucci
Merge branch 'master' into OR_NewYear_MG_NoWD up to PR openrails#712
65e39bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Csantucci Csantucci Csantucci approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cesarBLG @Csantucci @Sharpe49