Menu contents route name clash #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Installed" tab pushing the cancel button undoes the changes. However on the "Auto Installed" tab undoing a route installed or undoing updates to a route is not possible or logical.
…ed" tab. Implemented for deleting a row.
…orm: "Cancel: changes made in the 'Manually Installed' tab will not be saved, are you sure?". Saving will only be done when pressing the Ok button.
…for adding or changing a route.
…ich the route name is the same as an "Auto Installed" route, the manual name is changed by adding (1), (2) etc.
…me clashes can occur with local routes. This update renames the manual added route appending (1), (2) etc. This update does the same when automatic routes are added.
twpol
pushed a commit
that referenced
this pull request
Apr 29, 2025
- Pull request #570 at f11a428: glTF 2.0 support with PBR lighting - Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter - Pull request #1052 at 3b5cb90: Content Manager: Add axle count, and lowest derail force - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1066 at 62c89c1: Log derailment, using TraceInformation. - Pull request #1082 at a3128ae: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1049 at 6a0c471: Re-organise document storage and access - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1069 at 99fc9ac: Mouse wheel control only with Alt – Followup for #1051 - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1071 at 722dd3f: Change cover image for v1.6 - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1077 at 7e73abd: Fix SME brakes not working - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 5e37059: Adds Polish transations - Pull request #1080 at a637cb8: arranges Options > System tab for longer texts - Pull request #1083 at 7e6fb60: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
twpol
pushed a commit
that referenced
this pull request
Apr 29, 2025
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting - Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter - Pull request #1052 at 3b5cb90: Content Manager: Add axle count, and lowest derail force - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1066 at 62c89c1: Log derailment, using TraceInformation. - Pull request #1082 at a3128ae: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1049 at 6a0c471: Re-organise document storage and access - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1069 at 99fc9ac: Mouse wheel control only with Alt – Followup for #1051 - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1071 at 722dd3f: Change cover image for v1.6 - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1077 at 7e73abd: Fix SME brakes not working - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 5e37059: Adds Polish transations - Pull request #1080 at a637cb8: arranges Options > System tab for longer texts - Pull request #1083 at 7e6fb60: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
twpol
pushed a commit
that referenced
this pull request
May 1, 2025
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1066 at 62c89c1: Log derailment, using TraceInformation. - Pull request #1082 at ca0d8e5: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1069 at 99fc9ac: Mouse wheel control only with Alt – Followup for #1051 - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1077 at 7e73abd: Fix SME brakes not working - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 5e37059: Adds Polish transations - Pull request #1083 at 7e6fb60: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
twpol
pushed a commit
that referenced
this pull request
May 1, 2025
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1066 at 62c89c1: Log derailment, using TraceInformation. - Pull request #1082 at 5845a1a: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 5e37059: Adds Polish transations - Pull request #1083 at 7e6fb60: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
twpol
pushed a commit
that referenced
this pull request
May 3, 2025
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1066 at 62c89c1: Log derailment, using TraceInformation. - Pull request #1082 at 5845a1a: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 592e054: Adds Polish transations - Pull request #1083 at 6d0e99c: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
twpol
pushed a commit
that referenced
this pull request
May 3, 2025
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1082 at 5845a1a: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 592e054: Adds Polish transations - Pull request #1083 at 6d0e99c: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
twpol
pushed a commit
that referenced
this pull request
May 3, 2025
- Pull request #570 at 362e4e7: glTF 2.0 support with PBR lighting - Pull request #1062 at bbc0013: Train Forces popup Window. - Pull request #1064 at cb510d6: Add Train Info tab to Help window (F1) - Pull request #1082 at 5845a1a: Allow variable water level in glass gauge - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #1057 at 84592f7: Switchable brake system - Pull request #1070 at f818e40: Fix a NullReferenceException in TCS scripts - Pull request #1074 at e9a66c1: Gradient - commit 2024-16-12 - Pull request #1076 at 3bbd537: Allow depart early - Pull request #1078 at 9ab642e: Default PowerSupply script for steam locomotives - Pull request #1079 at 592e054: Adds Polish transations - Pull request #1083 at fc8adf7: Menu contents route name clash - Pull request #1081 at 689494b: Brake cuts power unification
cjakeman
approved these changes
May 4, 2025
Contributor
cjakeman
left a comment
cjakeman
left a comment
There was a problem hiding this comment.
Hi Siebren,
Working well (and thanks for adding the Trim()).
Approved.
Chris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever route names clashes occur, the route is renamed by appending (1), (2) etc.
Pressing cancel button issues a warning.
See commit comments for details.