Skip to content

Fix for PantographToggle sound event #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cesarBLG merged 2 commits into from
Apr 7, 2025
Merged

Fix for PantographToggle sound event #1065

cesarBLG merged 2 commits into from
Apr 7, 2025

Conversation

@cesarBLG
Copy link
Contributor

@cesarBLG cesarBLG commented Mar 28, 2025

@cesarBLG cesarBLG added the bug Something isn't working label Mar 28, 2025
twpol pushed a commit that referenced this pull request Mar 28, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 11 pull requests
f7ad19a 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at eb49b25: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@rwf-rr
Copy link
Contributor

rwf-rr commented Mar 28, 2025

I am a bit concerned that this change adds future risk.
Previously, the PantographToggle event was conditional to PowerSupplyEvent.RaisePantograph or PowerSupplyEvent.LowerPantograph.
Now, PantographToggle is handled on any event.
There currently seem to be only the two above events, but if another event were added in the future, there could be a problem.

And a question: the PantographToggle event is now conditional to there being a soundEvent. Is it reasonable to assume that there always will be a sound event?

@cesarBLG
Copy link
Contributor Author

cesarBLG commented Mar 28, 2025

A few comments:

  • In OR, Orts.Common.Event mostly means "sound event"
  • Previously, the pantograph toggle sound was linked to one of the possible ways the pantograph can be raised/lowered, which is incorrect.
  • Now, PantographToggle is handled when any pantograph-related event happens (that is, any pantograph is raised/lowered), which is the expected behaviour.
  • The 'soundEvent' is just a local variable that sets the event name whenever a pantograph changes state. Thus, whenever a pantograph changes, we trigger the specific event associated to it (i.e. 'soundEvent') as well as the generic PantographToggle sound event.

The original fix is from @Csantucci and I agree with it. This is the way to go, the previous behaviour was incorrect.

@rwf-rr
Copy link
Contributor

rwf-rr commented Mar 28, 2025

Thanks for the explanation, Cesar.

twpol pushed a commit that referenced this pull request Mar 28, 2025
@openrails-bot
Automatic merge of T1.5.1-1630-gf3424409b and 11 pull requests
ada1bb5 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at ffccb2e: Improvements for Power Supplies
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 11 pull requests
b404306 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
Csantucci
Csantucci approved these changes Mar 29, 2025
View reviewed changes
Copy link
Contributor

@Csantucci Csantucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 12 pull requests
d8d87d6 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 13 pull requests
88b3e3e 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1015 at 1ade99e: Enhancements for EP brakes
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #1055 at d133921: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Mar 29, 2025
@openrails-bot
Automatic merge of T1.5.1-1678-gf88b8b9b1 and 11 pull requests
fb65914 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1057 at cf3caa0: Switchable brake system
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1063 at 6c23191: Better Missing Track Section Error Message
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 30, 2025
@openrails-bot
Automatic merge of T1.5.1-1680-g0cd8cb893 and 13 pull requests
0ec6982 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1052 at 382ea6d: Content Manager: Add axle count, and lowest derail force
- Pull request #1057 at cf3caa0: Switchable brake system
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 30, 2025
@openrails-bot
Automatic merge of T1.5.1-1680-g0cd8cb893 and 14 pull requests
ee8cffc 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 382ea6d: Content Manager: Add axle count, and lowest derail force
- Pull request #1057 at cf3caa0: Switchable brake system
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 31, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
4e59b7b 
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 382ea6d: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Mar 31, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
6bca023 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 382ea6d: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Mar 31, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
8f1a7c1 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 382ea6d: Content Manager: Add axle count, and lowest derail force
- Pull request #1057 at 8566519: Switchable brake system
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 1, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
fa57fcb 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 17c8d18: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1067 at 777efaf: Traction and dynamic brake retardation
twpol pushed a commit that referenced this pull request Apr 1, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
809a4d4 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 17c8d18: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at d6bd4e3: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 2, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
6ffd284 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at d3f00a1: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at d6bd4e3: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 2, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
c7db763 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at d3f00a1: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 29a0d37: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 2, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
6eb9a1d 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 53dd604: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 29a0d37: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 2, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
0cd2224 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 29a0d37: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 3, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 14 pull requests
c8bc508 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at d9791e2: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 4, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 15 pull requests
47bb503 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at d9791e2: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #1055 at 90bbcff: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 4, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 15 pull requests
747c103 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 389c2d2: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #1055 at 90bbcff: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 4, 2025
@openrails-bot
Automatic merge of T1.5.1-1689-g72674c98d and 16 pull requests
2bc8fb1 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 389c2d2: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1068 at d6e1f83: Build for online-only documentation files
- Pull request #1069 at ffd1af4: Mouse wheel control only with Alt – Followup for #1051
- Pull request #1055 at 90bbcff: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 5, 2025
@openrails-bot
Automatic merge of T1.5.1-1692-g8b2dd97c0 and 15 pull requests
95ca8e9 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 50c3789: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1069 at ffd1af4: Mouse wheel control only with Alt – Followup for #1051
- Pull request #1055 at 90bbcff: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Apr 6, 2025
@openrails-bot
Automatic merge of T1.5.1-1692-g8b2dd97c0 and 16 pull requests
0b6d60c 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 50c3789: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1069 at ffd1af4: Mouse wheel control only with Alt – Followup for #1051
- Pull request #1055 at 90bbcff: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1049 at 4dd8c4f: Re-organise document storage and access
twpol pushed a commit that referenced this pull request Apr 6, 2025
@openrails-bot
Automatic merge of T1.5.1-1692-g8b2dd97c0 and 16 pull requests
ed639ad 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 50c3789: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1069 at 3f153f0: Mouse wheel control only with Alt – Followup for #1051
- Pull request #1055 at 90bbcff: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1049 at 4dd8c4f: Re-organise document storage and access
twpol pushed a commit that referenced this pull request Apr 7, 2025
@openrails-bot
Automatic merge of T1.5.1-1692-g8b2dd97c0 and 16 pull requests
42f4d56 
- Pull request #900 at 4629736: DMI in 3D cab + two more dials
- Pull request #1030 at d3ae4a2: Refactor settings, in prep for settings exporter
- Pull request #1045 at cc4d53c: Bugfix: Empty Start Time for Explore, and other issues loading from Menu Selection and Content Routes
- Pull request #1052 at 5bbc476: Content Manager: Add axle count, and lowest derail force
- Pull request #1062 at 3b18c48: Train Forces popup Window.
- Pull request #1064 at 9b3415e: Add Train Info tab to Help window (F1)
- Pull request #1066 at 62c89c1: Log derailment, using TraceInformation.
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #1000 at d8d9709: Locomotive operation from control car
- Pull request #1029 at 92c74ef: Superelevation Follow Up Fixes
- Pull request #1057 at 50c3789: Switchable brake system
- Pull request #1065 at 409064d: Fix for PantographToggle sound event
- Pull request #1069 at 3f153f0: Mouse wheel control only with Alt – Followup for #1051
- Pull request #1055 at f6bf9fa: Route Based TTrack Sounds
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
- Pull request #1049 at 4dd8c4f: Re-organise document storage and access
@cesarBLG
Copy link
Contributor Author

cesarBLG commented Apr 7, 2025

Thanks, Carlo

@cesarBLG cesarBLG merged commit ade0195 into openrails:master Apr 7, 2025
1 check passed
Csantucci added a commit to Csantucci/openrails that referenced this pull request Apr 22, 2025
@Csantucci
Merge branch 'master' up to PR openrails#1065
b658399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Csantucci Csantucci Csantucci approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cesarBLG @rwf-rr @Csantucci