Skip to content

Conversation

@twpol
Copy link
Member

@twpol twpol commented Mar 1, 2025

Before:

  • TrainCar is-over-junction did not work at all
  • Sound is-over-junction worked for switches but not crossovers

After:

  • New is-over-junction works for switches and crossovers
  • TrainCar and Sound both use same flag
  • Is-over-water-trough check also migrated to new code for simplicity

@twpol twpol self-assigned this Mar 1, 2025
twpol pushed a commit that referenced this pull request Mar 1, 2025
- Pull request #900 at b3679ba: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at efae37a: refactor: TrainCar junction detection
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 2, 2025
- Pull request #900 at b3679ba: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at 7e949c3: refactor: TrainCar junction detection
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 2, 2025
- Pull request #900 at b3679ba: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at ff5688f: refactor: TrainCar junction detection
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@cjakeman
Copy link
Contributor

cjakeman commented Mar 2, 2025

Hi James,

Isn't this called with every frame and every car in the train?
If so, it sounds a bit demanding for a lengthy train (but I've not made any measurements).

From the comments here:
// Scan through the track sections forwards from the REAR of the train
// stopping as soon as we've passed this car (checkedM) or run out of track
it looks as though we could do this once for the leading car and, if nothing is found, skip the remaining cars in the train.

Have I undestood the algorithm correctly?

Chris

twpol pushed a commit that referenced this pull request Mar 2, 2025
- Pull request #900 at b3679ba: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at ff5688f: refactor: TrainCar junction detection
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 3, 2025
- Pull request #900 at b3679ba: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at ff5688f: refactor: TrainCar junction detection
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
Copy link
Contributor

@peternewell peternewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi James,

Thanks for sorting this out.

twpol pushed a commit that referenced this pull request Mar 4, 2025
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at ff5688f: refactor: TrainCar junction detection
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Mar 5, 2025
- Pull request #900 at b54024b: DMI in 3D cab + two more dials
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at 4148bea: Improvements for Power Supplies
- Pull request #1015 at 14c132b: Enhancements for EP brakes
- Pull request #1021 at 3250dea: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 31fd7d2: Superelevation Follow Up Fixes
- Pull request #1031 at 34aa23a: Multiplayer Server, forked from Open Rails Ultimate; blueprint https://blueprints.launchpad.net/or/+spec/multiplayer-server
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1047 at b7152dc: Docs: adds translation docs
- Pull request #1050 at ff5688f: refactor: TrainCar junction detection
- Pull request #1051 at 0ac5d30: Mouse wheel support for cabview controls + refactor
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@cjakeman cjakeman merged commit da4b28b into openrails:master Mar 8, 2025
1 check passed
Csantucci added a commit to Csantucci/openrails that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants