Skip to content

Conversation

@SteelFill
Copy link
Contributor

Bug on Elvas Tower

A small oversight in the implementation of the service cylinder pressure limit was causing emergency applications to be vented down to the service cylinder pressure all the time. While the service pressure limit was correctly disabled for the actual level of application, the venting is handled separately and needed an additional check to be disabled for emergency applications.

@SteelFill SteelFill added the bug Something isn't working label Feb 9, 2025
twpol pushed a commit that referenced this pull request Feb 9, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1001 at 2ef2b6e: Telemetry collection and menu options #or-telemetry-system
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1021 at 7dec772: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1033 at 171dc86: Multiple signal light textures per signal
- Pull request #1036 at 04199ff: Trans: update Spanish
- Pull request #1041 at 748d6c1: Trans: updated Portuguese translations
- Pull request #1042 at 22a372b: Fix Emergency Brake Pressure Being Overridden
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Feb 9, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1001 at 2ef2b6e: Telemetry collection and menu options #or-telemetry-system
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1021 at 7dec772: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1033 at 171dc86: Multiple signal light textures per signal
- Pull request #1036 at 04199ff: Trans: update Spanish
- Pull request #1041 at 748d6c1: Trans: updated Portuguese translations
- Pull request #1042 at 22a372b: Fix Emergency Brake Pressure Being Overridden
- Pull request #1043 at c07432a: Updated French translations (OR Menu)
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Feb 9, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1001 at 2ef2b6e: Telemetry collection and menu options #or-telemetry-system
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1021 at 7dec772: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1033 at 171dc86: Multiple signal light textures per signal
- Pull request #1036 at 8c427b0: Trans: update Spanish
- Pull request #1041 at 748d6c1: Trans: updated Portuguese translations
- Pull request #1042 at 22a372b: Fix Emergency Brake Pressure Being Overridden
- Pull request #1043 at c07432a: Updated French translations (OR Menu)
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Feb 11, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1001 at 2ef2b6e: Telemetry collection and menu options #or-telemetry-system
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1015 at 3ee3108: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1033 at 171dc86: Multiple signal light textures per signal
- Pull request #1036 at 8c427b0: Trans: update Spanish
- Pull request #1041 at 748d6c1: Trans: updated Portuguese translations
- Pull request #1042 at 22a372b: Fix Emergency Brake Pressure Being Overridden
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
twpol pushed a commit that referenced this pull request Feb 11, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1001 at 2ef2b6e: Telemetry collection and menu options #or-telemetry-system
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1015 at 3ee3108: Enhancements for EP brakes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1036 at 8c427b0: Trans: update Spanish
- Pull request #1041 at 748d6c1: Trans: updated Portuguese translations
- Pull request #1042 at 22a372b: Fix Emergency Brake Pressure Being Overridden
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
Copy link
Contributor

@cesarBLG cesarBLG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

twpol pushed a commit that referenced this pull request Feb 12, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH
- Pull request #961 at eb9c601: Improvements for Power Supplies
- Pull request #1001 at 2ef2b6e: Telemetry collection and menu options #or-telemetry-system
- Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable.
- Pull request #1015 at 3ee3108: Enhancements for EP brakes
- Pull request #1021 at 96a1a59: Various traincar operations windows fixes
- Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771
- Pull request #1029 at 94cc8db: DynaTrax Support for Superelevation
- Pull request #1033 at 7efd355: Multiple signal light textures per signal
- Pull request #1036 at 8c427b0: Trans: update Spanish
- Pull request #1041 at 748d6c1: Trans: updated Portuguese translations
- Pull request #1042 at 22a372b: Fix Emergency Brake Pressure Being Overridden
- Pull request #900 at c27f32d: DMI updates
- Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder
- Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains
@SteelFill SteelFill merged commit 37eb09f into openrails:master Feb 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants