Fix: TrainDrivingInfo crashes if engineBrakeStatus is null. #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Jan 23, 2025
- Pull request #1007 at ad60314: Russian localization up to 2025 Jan 3-rd - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at eb9c601: Improvements for Power Supplies - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1021 at 5a7ba93: Various traincar operations windows fixes - Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771 - Pull request #1028 at c5f291d: Replace all compression code with System.IO.Compression - Pull request #1029 at 759b1a1: DynaTrax Support for Superelevation - Pull request #1033 at 171dc86: Multiple signal light textures per signal - Pull request #1035 at 36dcea4: Fix: TrainDrivingInfo crashes if engineBrakeStatus is null. - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1001 at 6d14344: Telemetry collection and menu options #or-telemetry-system - Pull request #1003 at 6013905: Clean up logging during loading #or-std-log - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Jan 23, 2025
- Pull request #1007 at ad60314: Russian localization up to 2025 Jan 3-rd - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at eb9c601: Improvements for Power Supplies - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771 - Pull request #1028 at c5f291d: Replace all compression code with System.IO.Compression - Pull request #1029 at 759b1a1: DynaTrax Support for Superelevation - Pull request #1033 at 171dc86: Multiple signal light textures per signal - Pull request #1035 at 36dcea4: Fix: TrainDrivingInfo crashes if engineBrakeStatus is null. - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1001 at 6d14344: Telemetry collection and menu options #or-telemetry-system - Pull request #1003 at 6013905: Clean up logging during loading #or-std-log - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Jan 23, 2025
- Pull request #1007 at ad60314: Russian localization up to 2025 Jan 3-rd - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at eb9c601: Improvements for Power Supplies - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1021 at 379ad30: Various traincar operations windows fixes - Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771 - Pull request #1028 at c5f291d: Replace all compression code with System.IO.Compression - Pull request #1029 at 759b1a1: DynaTrax Support for Superelevation - Pull request #1033 at 171dc86: Multiple signal light textures per signal - Pull request #1035 at 36dcea4: Fix: TrainDrivingInfo crashes if engineBrakeStatus is null. - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1001 at 6d14344: Telemetry collection and menu options #or-telemetry-system - Pull request #1003 at 6013905: Clean up logging during loading #or-std-log - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Jan 24, 2025
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at eb9c601: Improvements for Power Supplies - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1021 at 379ad30: Various traincar operations windows fixes - Pull request #1026 at 6a89a97: Fix for Multiplayer: remote trains chuff can't be heard https://bugs.launchpad.net/or/+bug/2092771 - Pull request #1029 at ac798e9: DynaTrax Support for Superelevation - Pull request #1033 at 171dc86: Multiple signal light textures per signal - Pull request #1035 at 36dcea4: Fix: TrainDrivingInfo crashes if engineBrakeStatus is null. - Pull request #900 at c27f32d: DMI updates - Pull request #1007 at ad60314: Russian localization up to 2025 Jan 3-rd - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1001 at 6d14344: Telemetry collection and menu options #or-telemetry-system - Pull request #1003 at 6013905: Clean up logging during loading #or-std-log - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
cesarBLG
approved these changes
Jan 25, 2025
Contributor
cesarBLG
left a comment
cesarBLG
left a comment
There was a problem hiding this comment.
It looks good to me, thanks for the fix!
Contributor
Author
|
Hi César, Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info here:
Bug #2096450