-
Notifications
You must be signed in to change notification settings - Fork 98
Various traincar operations windows fixes #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various traincar operations windows fixes #1021
Conversation
|
Hi Siebren, Regards, |
…cond - transferred some code from Viewer.cs to TrainCarOperationsWebpage.cs
…and-openrails/openrails into TrainCarOperationsBugfixes
|
hi Mauricio, I've messed things up, see above after sweiland-openrails added 2 commits I wanted to Commit and Push my fixes in the third commit. And it came with the extra commit Merging the branch from my fork. Does that undo your fix? If so do you know how to repair? regards, Siebren. |
|
This crash was detected in the ORNYMG version with the web server disabled. |
|
hi Mauricio, I did some testing. And the webserver can be in the process of starting when executing the above code. So for the three added question marks two of them are valid. The first one is not necessary as the if is testing for the field Viewer.TrainCarOperationsWebpage to be null. However it does not harm either. |
pzgulyas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't see codewise problems.
see launchpad bug https://bugs.launchpad.net/or/+bug/2095394