Skip to content

Conversation

@sweiland-openrails
Copy link
Contributor

@sweiland-openrails sweiland-openrails commented Dec 27, 2024

@mbm-OR mbm-OR added the bug Something isn't working label Dec 27, 2024
@mbm-OR
Copy link
Contributor

mbm-OR commented Jan 2, 2025

Hi Siebren,
When the Brake SystemType is Vacuum_single_pipe, the BrakeSystem.AngleCockAOpenAmount value will always be 1, so the AngleCocks will not work as required.

Regards,
Mauricio

@sweiland-openrails
Copy link
Contributor Author

hi Mauricio,

I've messed things up, see above after sweiland-openrails added 2 commits

I wanted to Commit and Push my fixes in the third commit. And it came with the extra commit Merging the branch from my fork. Does that undo your fix? If so do you know how to repair?

regards, Siebren.

@mbm-OR
Copy link
Contributor

mbm-OR commented Feb 26, 2025

This crash was detected in the ORNYMG version with the web server disabled.
@Csantucci created this fix.
Are we sure that the web server will never go down in our official version?

@sweiland-openrails
Copy link
Contributor Author

hi Mauricio,
I did resolve my conversation with the following comment:

I did some testing. And the webserver can be in the process of starting when executing the above code. So for the three added question marks two of them are valid. The first one is not necessary as the if is testing for the field Viewer.TrainCarOperationsWebpage to be null. However it does not harm either.

Copy link
Contributor

@pzgulyas pzgulyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see codewise problems.

@sweiland-openrails sweiland-openrails merged commit b2a8053 into openrails:master Mar 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

3 participants