-
Notifications
You must be signed in to change notification settings - Fork 98
Refactor namespaces in Menu #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cjakeman
merged 2 commits into
openrails:master
from
twpol:feature/consistent-namespaces/menu
Dec 29, 2024
Merged
Refactor namespaces in Menu #1018
cjakeman
merged 2 commits into
openrails:master
from
twpol:feature/consistent-namespaces/menu
Dec 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Dec 24, 2024
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 1c53db2: Multiple type trainset lightglows - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1012 at 33f692f: doc:adds 3 news items to Manual - Pull request #1015 at 266e9ca: Enhancements for EP brakes - Pull request #1017 at ef3bebb: Refactor namespaces in Launcher - Pull request #1018 at 620be18: Refactor namespaces in Menu - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1003 at c734592: Clean up logging during loading #or-std-log - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Dec 24, 2024
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 1c53db2: Multiple type trainset lightglows - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1012 at 33f692f: doc:adds 3 news items to Manual - Pull request #1015 at 266e9ca: Enhancements for EP brakes - Pull request #1017 at ef3bebb: Refactor namespaces in Launcher - Pull request #1018 at 620be18: Refactor namespaces in Menu - Pull request #1019 at f3fd253: Rename files and folder to correct case - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Dec 25, 2024
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 1c53db2: Multiple type trainset lightglows - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1012 at 33f692f: doc:adds 3 news items to Manual - Pull request #1015 at 266e9ca: Enhancements for EP brakes - Pull request #1017 at ef3bebb: Refactor namespaces in Launcher - Pull request #1018 at 620be18: Refactor namespaces in Menu - Pull request #1019 at f3fd253: Rename files and folder to correct case - Pull request #1020 at aa5f656: Bug fix for https://bugs.launchpad.net/or/+bug/2092489 Containers not appearing in timetable mode - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Dec 27, 2024
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 1c53db2: Multiple type trainset lightglows - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1012 at 33f692f: doc:adds 3 news items to Manual - Pull request #1015 at 266e9ca: Enhancements for EP brakes - Pull request #1017 at ef3bebb: Refactor namespaces in Launcher - Pull request #1018 at 620be18: Refactor namespaces in Menu - Pull request #1019 at f3fd253: Rename files and folder to correct case - Pull request #1020 at aa5f656: Bug fix for https://bugs.launchpad.net/or/+bug/2092489 Containers not appearing in timetable mode - Pull request #1021 at 0f744b3: Various traincar operations windows fixes - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
620be18 to
ad5ac8b
Compare
twpol
pushed a commit
that referenced
this pull request
Dec 27, 2024
- Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 1c53db2: Multiple type trainset lightglows - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1012 at 33f692f: doc:adds 3 news items to Manual - Pull request #1015 at 266e9ca: Enhancements for EP brakes - Pull request #1017 at ef3bebb: Refactor namespaces in Launcher - Pull request #1018 at ad5ac8b: Refactor namespaces in Menu - Pull request #1019 at f3fd253: Rename files and folder to correct case - Pull request #1020 at aa5f656: Bug fix for https://bugs.launchpad.net/or/+bug/2092489 Containers not appearing in timetable mode - Pull request #1021 at 0f744b3: Various traincar operations windows fixes - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
twpol
pushed a commit
that referenced
this pull request
Dec 27, 2024
- Pull request #1022 at efe1fd7: Fix invalid brake controller detection - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 1c53db2: Multiple type trainset lightglows - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1009 at 80172b8: Fix: TrainCarViewer overlaps when display size changed - Pull request #1010 at 6a1060f: Fix: TrainDrivingInfo window width not stable. - Pull request #1012 at 33f692f: doc:adds 3 news items to Manual - Pull request #1015 at 266e9ca: Enhancements for EP brakes - Pull request #1017 at ef3bebb: Refactor namespaces in Launcher - Pull request #1018 at ad5ac8b: Refactor namespaces in Menu - Pull request #1019 at f3fd253: Rename files and folder to correct case - Pull request #1020 at aa5f656: Bug fix for https://bugs.launchpad.net/or/+bug/2092489 Containers not appearing in timetable mode - Pull request #1021 at 0f744b3: Various traincar operations windows fixes - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #896 at f1681df: First implementation of https://blueprints.launchpad.net/or/+spec/specific-sounds-for-ai-trains - Pull request #1016 at 5a94c4e: Route all logging via Trace #or-std-log
cjakeman
approved these changes
Dec 29, 2024
Contributor
cjakeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi James,
No issues. Approved and merged. Thanks,
Chris
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Architecture: https://github.com/openrails/openrails/blob/master/Docs/Architecture.md#projects-assemblies-namespaces