Bugfix: Content Form exception when there is manually installed content in a top level directory. #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a small typo in a variable name.
sweiland-openrails
approved these changes
Nov 28, 2024
Contributor
sweiland-openrails
left a comment
sweiland-openrails
left a comment
There was a problem hiding this comment.
Thanks for fixing this. Testing ok. Never thought of adding just a drive and an empty name would be possible.
I do not like the continue and break statement that much, reminds me of a goto. But that's personal, leave it as it is.
regards, Siebren.
Csantucci
added
the
for-unstable
twpol
pushed a commit
that referenced
this pull request
Nov 28, 2024
- Pull request #1006 at 9c13d51: Bugfix: Content Form exception when there is manually installed content in a top level directory. - Pull request #891 at 9a1d6b2: Auto save - Pull request #892 at 1f5ba4c: Signal Function OPP_SIG_ID_TRAINPATH - Pull request #953 at a519452: Fix Lights Crash on Corrupt Shapes - Pull request #961 at 8a9c8f9: Improvements for Power Supplies - Pull request #981 at 10d297f: Multiple type trainset lightglows - Pull request #995 at 95da33b: Fix: TrainCarOperations and TrainOperationsViewer windows overlap. - Pull request #996 at 2fcbcde: Replace dynamic brakes by engine brakes at low speeds - Pull request #1004 at 1828d97: Bugfix/fix train car operations brakehoses not sync coupling cars - Pull request #900 at c27f32d: DMI updates - Pull request #876 at f92de76: docs: add source for documents previously on website to source Documentation folder - Pull request #1003 at c734592: Clean up logging during loading #or-std-log
Csantucci
added a commit
to Csantucci/openrails
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manually installed content has a path of only a top level directory, eg. "H:", then the Content form of the main Menu (Content button) will crash with an exception. The problem is in the code that attempts to find the most used content directory.
The fix is to ignore content that is installed in a directory without a parent directory.
The commit also includes fixing a simple typo in a variable name.
See also:
https://bugs.launchpad.net/or/+bug/2089801
https://www.elvastower.com/forums/index.php?/topic/38414-crash-with-content-manager/page__view__findpost__p__313090