Skip to content

Fix RouterNodeConfigurationStatus FailedResources - missing L3VPN - #761

Open
andreaskaris wants to merge 2 commits into
openperouter:mainfrom
andreaskaris:fix-failed-resources-srv6
Open

Fix RouterNodeConfigurationStatus FailedResources - missing L3VPN#761
andreaskaris wants to merge 2 commits into
openperouter:mainfrom
andreaskaris:fix-failed-resources-srv6

Conversation

@andreaskaris

@andreaskaris andreaskaris commented Sep 14, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Is this a BUG FIX or a FEATURE ?:

/kind bug

What this PR does / why we need it:

Fix RouterNodeConfigurationStatus FailedResources reporting - L3VPN was missing and it would show:

Unsupported value: \"L3VPN\": supported values: \"Underlay\", \"L2VNI\", \"L3VNI\", \"FrrConfiguration\", \"L3Passthrough\"]"}

Special notes for your reviewer:
N/A

Release note:

Fix RouterNodeConfigurationStatus FailedResources reporting - add missing L3VPN.

AI Guidelines Acknowledgment:

  • I have reviewed all changes in this PR, including any AI-generated content, and I take full responsibility for its accuracy and correctness.

Summary by CodeRabbit

  • New Features

    • L3VPN is now recognized as a valid failed resource type in router node configuration status.

  • Documentation

    • Updated API references and deployment schemas to document and accept L3VPN failed resources.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 1a4d905a-1429-4f66-bed2-4526fa421609

📥 Commits

Reviewing files that changed from the base of the PR and between 3f4527c and 3582e48.

📒 Files selected for processing (8)
  • API-DOCS.md
  • api/v1alpha1/failedresource.go
  • charts/openperouter/charts/crds/templates/network.openperouter.io_routernodeconfigurationstatuses.yaml
  • config/all-in-one/crio.yaml
  • config/all-in-one/openpe.yaml
  • config/crd/bases/network.openperouter.io_routernodeconfigurationstatuses.yaml
  • operator/bundle/manifests/network.openperouter.io_routernodeconfigurationstatuses.yaml
  • website/content/docs/api-reference.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The change updates FailedResource.kind validation and related CRD schemas. The Go validation marker adds L3VNI. API documentation and generated CRD artifacts add L3VPN.

Changes

Failed resource enum support

Layer / File(s) Summary
Enum declarations and API documentation
api/v1alpha1/failedresource.go, API-DOCS.md, website/content/docs/api-reference.md		 The Go validation marker adds L3VNI. The API documentation adds L3VPN to the documented enum lists.
CRD schema propagation
charts/openperouter/charts/crds/templates/..., config/all-in-one/*.yaml, config/crd/bases/..., operator/bundle/manifests/...		 The CRD schemas and bundle manifests add L3VPN to the FailedResource.kind enum.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: qinqon, ormergi

Merge Risk: ⚪ Minimal · up to 0ba7c

The PR consistently enables L3VPN failed-resource reporting across the API and deployed schemas, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix and the missing L3VPN value in RouterNodeConfigurationStatus FailedResources.
Description check ✅ Passed The description includes the bug classification, change rationale, reviewer notes, release note, and completed AI acknowledgment. It matches the pull request objective and provides the relevant error …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@andreaskaris
fix(srv6): add missing L3VPN to FailedResourceKind
5c16d77 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
fix(srv6): auto-generated code for FailedResources fix
0ba7cf6 
make generate && \
  make manifests && \
  make bumplicense && \
  make generate-all-in-one && \
  make bundle && \
  make generate-all-ci

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
andreaskaris force-pushed the fix-failed-resources-srv6 branch from 3582e48 to 0ba7cf6 Compare September 14, 2026 15:58
@andreaskaris andreaskaris reopened this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@andreaskaris