Skip to content

Dockerfile: bundle the vlan and tuning CNI plugins - #760

Open
fivetime wants to merge 1 commit into
openperouter:mainfrom
fivetime:bundle-vlan-tuning
Open

fivetime wants to merge 1 commit into
openperouter:mainfrom
fivetime:bundle-vlan-tuning

Conversation

@fivetime

Copy link
Copy Markdown

Is this a BUG FIX or a FEATURE ?:

/kind feature

What this PR does / why we need it:

CNIDevice accepts CNI configurations, but the controller image does not contain vlan or tuning. A configuration requesting either plugin therefore fails plugin lookup unless users supply external binaries or rebuild the image.

The existing CNI builder already compiles both plugins. Copy them into /opt/openperouter/cni/bin/ alongside the existing plugins and document the available bundle. This enables tagged VLAN underlays using the existing IPAM plugins and chained interface tuning, such as MTU changes.

Special notes for your reviewer:

  • This is two additional Dockerfile COPY instructions plus the configuration reference update. The upstream CNI repository and pinned revision are unchanged.
  • VLAN still requires IPAM at the pinned revision. Optional IPAM is proposed independently in vlan: make IPAM optional for L2-only interfaces containernetworking/plugins#1302; this PR does not depend on that change or a personal fork.
  • Built the complete image locally on Linux amd64 with docker build -t local/openperouter:bundle-vlan-tuning-review ..
  • Both bundled binaries successfully handle CNI_COMMAND=VERSION inside the resulting image.
  • A smoke test in an isolated container and child network namespace verified VLAN ID 123, static IPAM address assignment, a chained tuning ADD setting MTU 1400, and tuning/VLAN DEL cleanup.
  • git diff --check passes. No live-cluster end-to-end test or local arm64 build was run.

Release note:

The controller image now includes the vlan and tuning CNI plugins for tagged underlay interfaces and chained interface configuration.

AI Guidelines Acknowledgment:

  • I have reviewed all changes in this PR, including any AI-generated content, and I take full responsibility for its accuracy and correctness.

CNIDevice configurations can request VLAN interfaces and chained tuning,
but the image omits both plugins even though the builder produces them.
Copy them into the existing plugin directory and document the bundle.

Signed-off-by: Simon Zhou <jp.zdm2008@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e56a0a50-9c02-4f72-af2b-c931f018ae56

📥 Commits

Reviewing files that changed from the base of the PR and between e435a85 and 17a7abc.

📒 Files selected for processing (2)
  • Dockerfile
  • website/content/docs/configuration/_index.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maiqueb
maiqueb self-requested a review September 14, 2026 08:22
@maiqueb maiqueb self-assigned this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants