API: replace bridge autoCreate with a lifecycle enum - #626
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (47)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (38)
📝 WalkthroughWalkthroughBridge configuration now uses a required ChangesBridge lifecycle configuration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/v1alpha1/l2vni_types.go`:
- Around line 149-165: Preserve a transitional autoCreate-compatible
representation and conversion for existing managed L2VNI resources in
api/v1alpha1/l2vni_types.go, accepting empty Lifecycle with no Name as the
legacy managed form and converting it to the correct managed behavior. Update
the CRD schemas in
charts/openperouter/charts/crds/templates/network.openperouter.io_l2vnis.yaml
(71-120), config/all-in-one/crio.yaml (80-129), config/all-in-one/openpe.yaml
(80-129), config/crd/bases/network.openperouter.io_l2vnis.yaml (71-120), and
operator/bundle/manifests/network.openperouter.io_l2vnis.yaml (71-120) to accept
the legacy autoCreate shape during migration; do not make lifecycle required
until existing objects have been migrated.
In `@internal/conversion/host_conversion_test.go`:
- Line 475: Update the HostMaster fixture in the relevant conversion test to set
LinuxBridge.Lifecycle explicitly to BridgeLifecycleExternal, ensuring it
verifies the External-to-AutoCreate=false conversion; add a separate Managed
fixture/assertion that verifies the mapping to AutoCreate=true.
In `@website/content/docs/configuration/srv6.md`:
- Line 252: Replace the remaining explanatory references to
hostmaster.autocreate with documentation for lifecycle: Managed in
website/content/docs/configuration/srv6.md lines 252-252,
website/content/docs/examples/evpnexamples/kubevirt-multi-cluster.md lines
82-82, website/content/docs/examples/evpnexamples/kubevirt.md lines 78-78,
website/content/docs/examples/evpnexamples/layer2.md lines 72-72, and
website/content/docs/examples/srv6examples/layer2.md lines 89-89; update each
adjacent note or configuration entry while preserving the existing YAML
examples.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 16eb1d7e-d798-4e34-a4cf-1062e34d3d77
📒 Files selected for processing (47)
API-DOCS.mdapi/v1alpha1/l2vni_types.goapi/v1alpha1/zz_generated.deepcopy.gocharts/openperouter/charts/crds/templates/network.openperouter.io_l2vnis.yamlconfig/all-in-one/crio.yamlconfig/all-in-one/openpe.yamlconfig/crd/bases/network.openperouter.io_l2vnis.yamlconfig/samples/l2vni-nodeselector-at-workers.yamlconfig/samples/l2vni-nodeselector-different-racks.yamlconfig/samples/l2vni-ovs.yamlconfig/samples/l2vni.yamle2etests/scale_tests/scale.goe2etests/tests/bridgerefresh.goe2etests/tests/evpn_l2.goe2etests/tests/frr_restart.goe2etests/tests/ipv6_vtep.goe2etests/tests/l3vpn_l2.goe2etests/tests/resiliency.goe2etests/tests/singlesession.goe2etests/tests/systemd_resiliency.goe2etests/tests/underlay_address_families.goexamples/evpn/cni-underlay/openpe.yamlexamples/evpn/kubevirt/openpe.yamlexamples/evpn/layer2/openpe.yamlexamples/evpn/multi-cluster/cluster-a-migration-l2vni.yamlexamples/evpn/multi-cluster/cluster-a-openpe.yamlexamples/evpn/multi-cluster/cluster-b-migration-l2vni.yamlexamples/evpn/multi-cluster/cluster-b-openpe.yamlexamples/l3vpn/layer2/openpe.yamlinternal/controller/routerconfiguration/static_configuration_reader_test.gointernal/conversion/host_conversion.gointernal/conversion/host_conversion_test.gointernal/conversion/validate_vni_test.gointernal/crdschema/crdschema_test.gointernal/crdschema/parity_test.gointernal/staticconfiguration/reader_test.gointernal/staticconfiguration/testdata/openpe_l2vni.yamlinternal/staticconfiguration/testdata/openpe_l3vpn.yamloperator/bundle/manifests/network.openperouter.io_l2vnis.yamlwebsite/content/docs/api-reference.mdwebsite/content/docs/configuration/evpn.mdwebsite/content/docs/configuration/node-selector.mdwebsite/content/docs/configuration/srv6.mdwebsite/content/docs/examples/evpnexamples/kubevirt-multi-cluster.mdwebsite/content/docs/examples/evpnexamples/kubevirt.mdwebsite/content/docs/examples/evpnexamples/layer2.mdwebsite/content/docs/examples/srv6examples/layer2.md
💤 Files with no reviewable changes (1)
- api/v1alpha1/zz_generated.deepcopy.go
| }, | ||
| L2GatewayIPs: []string{"192.168.100.1/24"}, | ||
| HostMaster: &hostnetwork.HostMaster{Name: new("br0"), Type: "linux-bridge"}, | ||
| HostMaster: &hostnetwork.HostMaster{Name: new("br0"), Type: "linux-bridge", AutoCreate: new(false)}, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use an explicit External lifecycle in this fixture.
The input fixture sets a bridge name but omits required Lifecycle, so this expectation validates the zero-value fallback rather than the External-to-AutoCreate=false conversion. Set LinuxBridge.Lifecycle to BridgeLifecycleExternal in the fixture; add a Managed case separately to cover the true mapping.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@internal/conversion/host_conversion_test.go` at line 475, Update the
HostMaster fixture in the relevant conversion test to set LinuxBridge.Lifecycle
explicitly to BridgeLifecycleExternal, ensuring it verifies the
External-to-AutoCreate=false conversion; add a separate Managed
fixture/assertion that verifies the mapping to AutoCreate=true.
qinqon
force-pushed
the
api-bridge-lifecycle
branch
2 times, most recently
from
July 28, 2026 12:03
b4aad33 to
9f2fbd3
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
website/content/docs/configuration/evpn.md (1)
201-203: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDocument the External condition explicitly.
Replace “Managed or a name is set” with “Managed, or External with
nameset” so the documented behavior matches the lifecycle contract and does not imply that name presence alone selects the behavior.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@website/content/docs/configuration/evpn.md` around lines 201 - 203, Update the host-veth connection description in the documented lifecycle behavior to state “Managed, or External with name set,” replacing the current “Managed or a name is set” wording while leaving the surrounding bridge behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/content/docs/configuration/evpn.md`:
- Around line 167-170: Update the bridge configuration table entries for
hostmaster.linuxBridge.lifecycle and hostmaster.ovsBridge.lifecycle to state
that the lifecycle for the bridge selected by hostmaster.type is required,
rather than marking both fields unconditionally required. Clarify the
corresponding name-row requiredness and replace the duplicated “Only” wording
with concise conditional text.
---
Nitpick comments:
In `@website/content/docs/configuration/evpn.md`:
- Around line 201-203: Update the host-veth connection description in the
documented lifecycle behavior to state “Managed, or External with name set,”
replacing the current “Managed or a name is set” wording while leaving the
surrounding bridge behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c53c8a5f-0324-47dc-ab8c-de8c8bc157c5
📒 Files selected for processing (47)
API-DOCS.mdapi/v1alpha1/l2vni_types.goapi/v1alpha1/zz_generated.deepcopy.gocharts/openperouter/charts/crds/templates/network.openperouter.io_l2vnis.yamlconfig/all-in-one/crio.yamlconfig/all-in-one/openpe.yamlconfig/crd/bases/network.openperouter.io_l2vnis.yamlconfig/samples/l2vni-nodeselector-at-workers.yamlconfig/samples/l2vni-nodeselector-different-racks.yamlconfig/samples/l2vni-ovs.yamlconfig/samples/l2vni.yamle2etests/scale_tests/scale.goe2etests/tests/bridgerefresh.goe2etests/tests/evpn_l2.goe2etests/tests/frr_restart.goe2etests/tests/ipv6_vtep.goe2etests/tests/l3vpn_l2.goe2etests/tests/resiliency.goe2etests/tests/singlesession.goe2etests/tests/systemd_resiliency.goe2etests/tests/underlay_address_families.goexamples/evpn/cni-underlay/openpe.yamlexamples/evpn/kubevirt/openpe.yamlexamples/evpn/layer2/openpe.yamlexamples/evpn/multi-cluster/cluster-a-migration-l2vni.yamlexamples/evpn/multi-cluster/cluster-a-openpe.yamlexamples/evpn/multi-cluster/cluster-b-migration-l2vni.yamlexamples/evpn/multi-cluster/cluster-b-openpe.yamlexamples/l3vpn/layer2/openpe.yamlinternal/controller/routerconfiguration/static_configuration_reader_test.gointernal/conversion/host_conversion.gointernal/conversion/host_conversion_test.gointernal/conversion/validate_vni_test.gointernal/crdschema/crdschema_test.gointernal/crdschema/parity_test.gointernal/staticconfiguration/reader_test.gointernal/staticconfiguration/testdata/openpe_l2vni.yamlinternal/staticconfiguration/testdata/openpe_l3vpn.yamloperator/bundle/manifests/network.openperouter.io_l2vnis.yamlwebsite/content/docs/api-reference.mdwebsite/content/docs/configuration/evpn.mdwebsite/content/docs/configuration/node-selector.mdwebsite/content/docs/configuration/srv6.mdwebsite/content/docs/examples/evpnexamples/kubevirt-multi-cluster.mdwebsite/content/docs/examples/evpnexamples/kubevirt.mdwebsite/content/docs/examples/evpnexamples/layer2.mdwebsite/content/docs/examples/srv6examples/layer2.md
💤 Files with no reviewable changes (1)
- api/v1alpha1/zz_generated.deepcopy.go
🚧 Files skipped from review as they are similar to previous changes (44)
- examples/l3vpn/layer2/openpe.yaml
- config/samples/l2vni-ovs.yaml
- internal/staticconfiguration/testdata/openpe_l3vpn.yaml
- config/samples/l2vni.yaml
- internal/staticconfiguration/testdata/openpe_l2vni.yaml
- examples/evpn/multi-cluster/cluster-a-migration-l2vni.yaml
- config/samples/l2vni-nodeselector-different-racks.yaml
- website/content/docs/configuration/srv6.md
- examples/evpn/kubevirt/openpe.yaml
- examples/evpn/multi-cluster/cluster-b-migration-l2vni.yaml
- internal/conversion/host_conversion_test.go
- examples/evpn/multi-cluster/cluster-b-openpe.yaml
- examples/evpn/layer2/openpe.yaml
- e2etests/tests/frr_restart.go
- config/crd/bases/network.openperouter.io_l2vnis.yaml
- website/content/docs/examples/srv6examples/layer2.md
- internal/staticconfiguration/reader_test.go
- internal/conversion/host_conversion.go
- e2etests/tests/underlay_address_families.go
- charts/openperouter/charts/crds/templates/network.openperouter.io_l2vnis.yaml
- website/content/docs/configuration/node-selector.md
- config/all-in-one/openpe.yaml
- e2etests/tests/resiliency.go
- e2etests/tests/singlesession.go
- operator/bundle/manifests/network.openperouter.io_l2vnis.yaml
- examples/evpn/cni-underlay/openpe.yaml
- config/all-in-one/crio.yaml
- website/content/docs/examples/evpnexamples/kubevirt.md
- examples/evpn/multi-cluster/cluster-a-openpe.yaml
- API-DOCS.md
- website/content/docs/examples/evpnexamples/layer2.md
- e2etests/tests/bridgerefresh.go
- e2etests/tests/ipv6_vtep.go
- internal/conversion/validate_vni_test.go
- website/content/docs/api-reference.md
- e2etests/tests/systemd_resiliency.go
- website/content/docs/examples/evpnexamples/kubevirt-multi-cluster.md
- config/samples/l2vni-nodeselector-at-workers.yaml
- e2etests/tests/l3vpn_l2.go
- e2etests/tests/evpn_l2.go
- api/v1alpha1/l2vni_types.go
- internal/crdschema/crdschema_test.go
- internal/crdschema/parity_test.go
- internal/controller/routerconfiguration/static_configuration_reader_test.go
This was referenced Jul 28, 2026
qinqon
force-pushed
the
api-bridge-lifecycle
branch
from
July 28, 2026 12:30
9f2fbd3 to
edfadaf
Compare
RamLavi
suggested changes
Jul 29, 2026
| type: linux-bridge | ||
| linuxBridge: | ||
| autoCreate: true | ||
| lifecycle: Managed |
Contributor
| hostmaster: | ||
| type: linux-bridge | ||
| linuxBridge: | ||
| autoCreate: true |
Contributor
There was a problem hiding this comment.
ditto. look for hostmaster.autocreate
| hostmaster: | ||
| type: linux-bridge | ||
| linuxBridge: | ||
| autoCreate: true |
Contributor
There was a problem hiding this comment.
ditto. look for hostmaster.autocreate
| hostmaster: | ||
| type: linux-bridge | ||
| linuxBridge: | ||
| autoCreate: true |
Contributor
There was a problem hiding this comment.
ditto. look for hostmaster.autocreate
|
|
||
| const ( | ||
| // BridgeLifecycleManaged means the controller creates and owns the | ||
| // bridge, named br-hs-<VNI>, and deletes it when the L2VNI is removed. |
Contributor
There was a problem hiding this comment.
enhancement says:
// BridgeLifecycleManaged means the controller creates and owns
// the bridge, and deletes it when the L2VNI is removed. If Name is
// omitted, the bridge is auto-named br-hs-<VNI>. If Name is
// provided, the controller creates the bridge with that name.
BridgeLifecycleManaged BridgeLifecycle = "Managed"
reading this one could understand that name + Managed should be a valid combination.
Howiever in this PR - the comment is droped entirely, and the CEL rule
((self.?name.orValue("") != "") != (self.?lifecycle.orValue("") == 'Managed'))
actively forbids setting name when lifecycle: Managed is dropping the custom-named-Managed-bridge capability intentionally
So, I'm confused. Can you explain which is correct?
Contributor
There was a problem hiding this comment.
I guess it's a good point.
Which would we want to follow ? IMHO it can be either way - but, if we stick to the existing behavior, it should be an exclusive or. Not sure we want to do that.
Contributor
There was a problem hiding this comment.
But it just means we need to have @fedepaol 's blessing.
Contributor
Author
There was a problem hiding this comment.
@RamLavi originally I was implementing adding Name when managed, but I decided to keep current behaviour to reduce PR size, we can implement follow up PR to support Name + Managed as a new feature.
I want the PR to be just about the k8s API, in fact I keep the internal structures with the autoCreate boolean.
Contributor
There was a problem hiding this comment.
IMHO, that makes sense. We can change the behavior later - but if we want that, we need to move rather soon.
qinqon
force-pushed
the
api-bridge-lifecycle
branch
from
July 29, 2026 13:41
edfadaf to
d564e37
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@API-DOCS.md`:
- Around line 581-582: Update the source descriptions for the Linux and OVS
bridge name fields to state that External bridges require a non-empty name,
while Managed bridges must omit name; then regenerate the artifacts. Apply the
generated description updates at API-DOCS.md lines 581-582 and 676-677,
website/content/docs/api-reference.md lines 589-590 and 684-685, and
config/all-in-one/crio.yaml lines 89-91 and 116-118.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b667b83c-08f6-485a-a7f0-bd8056fcf550
📒 Files selected for processing (47)
API-DOCS.mdapi/v1alpha1/l2vni_types.goapi/v1alpha1/zz_generated.deepcopy.gocharts/openperouter/charts/crds/templates/network.openperouter.io_l2vnis.yamlconfig/all-in-one/crio.yamlconfig/all-in-one/openpe.yamlconfig/crd/bases/network.openperouter.io_l2vnis.yamlconfig/samples/l2vni-nodeselector-at-workers.yamlconfig/samples/l2vni-nodeselector-different-racks.yamlconfig/samples/l2vni-ovs.yamlconfig/samples/l2vni.yamle2etests/scale_tests/scale.goe2etests/tests/bridgerefresh.goe2etests/tests/evpn_l2.goe2etests/tests/frr_restart.goe2etests/tests/ipv6_vtep.goe2etests/tests/l3vpn_l2.goe2etests/tests/resiliency.goe2etests/tests/singlesession.goe2etests/tests/systemd_resiliency.goe2etests/tests/underlay_address_families.goexamples/evpn/cni-underlay/openpe.yamlexamples/evpn/kubevirt/openpe.yamlexamples/evpn/layer2/openpe.yamlexamples/evpn/multi-cluster/cluster-a-migration-l2vni.yamlexamples/evpn/multi-cluster/cluster-a-openpe.yamlexamples/evpn/multi-cluster/cluster-b-migration-l2vni.yamlexamples/evpn/multi-cluster/cluster-b-openpe.yamlexamples/l3vpn/layer2/openpe.yamlinternal/controller/routerconfiguration/static_configuration_reader_test.gointernal/conversion/host_conversion.gointernal/conversion/host_conversion_test.gointernal/conversion/validate_vni_test.gointernal/crdschema/crdschema_test.gointernal/crdschema/parity_test.gointernal/staticconfiguration/reader_test.gointernal/staticconfiguration/testdata/openpe_l2vni.yamlinternal/staticconfiguration/testdata/openpe_l3vpn.yamloperator/bundle/manifests/network.openperouter.io_l2vnis.yamlwebsite/content/docs/api-reference.mdwebsite/content/docs/configuration/evpn.mdwebsite/content/docs/configuration/node-selector.mdwebsite/content/docs/configuration/srv6.mdwebsite/content/docs/examples/evpnexamples/kubevirt-multi-cluster.mdwebsite/content/docs/examples/evpnexamples/kubevirt.mdwebsite/content/docs/examples/evpnexamples/layer2.mdwebsite/content/docs/examples/srv6examples/layer2.md
💤 Files with no reviewable changes (1)
- api/v1alpha1/zz_generated.deepcopy.go
🚧 Files skipped from review as they are similar to previous changes (37)
- config/samples/l2vni.yaml
- internal/staticconfiguration/testdata/openpe_l2vni.yaml
- config/samples/l2vni-nodeselector-different-racks.yaml
- internal/conversion/host_conversion_test.go
- config/samples/l2vni-ovs.yaml
- examples/l3vpn/layer2/openpe.yaml
- examples/evpn/cni-underlay/openpe.yaml
- website/content/docs/examples/srv6examples/layer2.md
- internal/staticconfiguration/testdata/openpe_l3vpn.yaml
- examples/evpn/layer2/openpe.yaml
- charts/openperouter/charts/crds/templates/network.openperouter.io_l2vnis.yaml
- internal/conversion/host_conversion.go
- website/content/docs/configuration/srv6.md
- website/content/docs/examples/evpnexamples/kubevirt-multi-cluster.md
- e2etests/tests/singlesession.go
- website/content/docs/examples/evpnexamples/layer2.md
- examples/evpn/multi-cluster/cluster-b-openpe.yaml
- examples/evpn/multi-cluster/cluster-a-openpe.yaml
- e2etests/tests/systemd_resiliency.go
- website/content/docs/configuration/node-selector.md
- examples/evpn/multi-cluster/cluster-a-migration-l2vni.yaml
- internal/conversion/validate_vni_test.go
- config/all-in-one/openpe.yaml
- e2etests/tests/resiliency.go
- internal/crdschema/parity_test.go
- operator/bundle/manifests/network.openperouter.io_l2vnis.yaml
- examples/evpn/multi-cluster/cluster-b-migration-l2vni.yaml
- config/crd/bases/network.openperouter.io_l2vnis.yaml
- e2etests/tests/bridgerefresh.go
- internal/staticconfiguration/reader_test.go
- e2etests/tests/underlay_address_families.go
- api/v1alpha1/l2vni_types.go
- e2etests/tests/ipv6_vtep.go
- e2etests/tests/evpn_l2.go
- e2etests/tests/l3vpn_l2.go
- internal/controller/routerconfiguration/static_configuration_reader_test.go
- internal/crdschema/crdschema_test.go
qinqon
force-pushed
the
api-bridge-lifecycle
branch
from
July 29, 2026 13:58
d564e37 to
b82e31b
Compare
Contributor
|
@qinqon I've rebased using the magic button ... Please rebase it yourself, and re-push. I just wanted to check how much better would CI run on the PR. |
Booleans cannot be extended to a third state and do not convey intent. Replace autoCreate with a lifecycle enum: Managed for the controller owned br-hs-<VNI> bridge, External for a user provided one. A name stays valid only for External bridges, as it was with the boolean. Assisted-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Output of make generate-all-ci, no hand written changes. Assisted-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Replace autoCreate: true with lifecycle: Managed, and a bare bridge name with lifecycle: External plus the name. Assisted-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
The host network layer keeps its own representation, so the enum is translated into the existing flag during conversion. No behaviour change. Assisted-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Declare Managed or External instead of the auto create toggle; fixtures attaching to a pre existing bridge become External. Assisted-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
api-bridge-lifecycle
branch
from
July 29, 2026 15:18
5d6e730 to
0fd79a3
Compare
Contributor
Author
Done |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
/kind feature
What this PR does / why we need it:
Implements part of the Replace Boolean Fields
section of the API improvements enhancement:
autoCreateonLinuxBridgeConfigandOVSBridgeConfigis replaced by alifecycleenum.
The enum carries exactly the two meanings the boolean already had:
autoCreate: truelifecycle: Managed— controller creates and owns the bridge, namedbr-hs-<VNI>, and deletes it with the L2VNIname: <bridge>lifecycle: External+name: <bridge>— user provides a pre-existing bridge, never created or deleted by the controllerThe mutual exclusivity is preserved, just expressed on the enum:
Special notes for your reviewer:
N/S
Release note:
AI Guidelines Acknowledgment:
Summary by CodeRabbit
Summary
lifecycleoption (Managed or External) for both Linux and OVS bridges.autoCreatewith requiredlifecycle.name; Managed forbidsname.lifecycle.