e2e: remove unused blue VNI from iBGP test#404
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a cleanup of the iBGP E2E test suite by removing redundant configuration objects and associated logic that were no longer required for validating connectivity. By focusing the test solely on the 'red' host and removing the 'blue' VNI, the codebase is simplified and dead logic for IPv6 handling is eliminated. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the EVPN routes e2e tests by removing the 'blue' VNI configuration and its associated test logic, focusing the test suite on the 'red' hosts. Additionally, it refactors CIDR handling by removing unused IPv6 logic and reorders imports. Feedback was provided regarding a redundant type cast in the FRR configuration assignment that should be removed to improve code clarity.
Remove the "blue" L3VNI definition and all its references from the iBGP E2E test, which only validates connectivity against the red host. This also removes dead code for IPv6 local CIDR selection, since the test hardcodes IPv4.
andreaskaris
force-pushed
the
cleanup-ibgp
branch
from
3cd1e6b to
3abca7a
Compare
1 participant
Remove the "blue" L3VNI definition and all its references from the iBGP
E2E test, which only validates connectivity against the red host. This
also removes dead code for IPv6 local CIDR selection, since the test
hardcodes IPv4.
Is this a BUG FIX or a FEATURE ?:
/kind cleanup
What this PR does / why we need it:
Remove the "blue" L3VNI definition and all its references from the iBGP
E2E test, which only validates connectivity against the red host. This
also removes dead code for IPv6 local CIDR selection, since the test
hardcodes IPv4.
Special notes for your reviewer:
N/A
Release note: