Skip to content

Conversation

@dwhswenson
Copy link
Member

Somehow I forgot to add this in git; had it in local checkout.

Somehow I forgot to add this in git; had it in local checkout.
@dwhswenson dwhswenson added the bug Something isn't working label Aug 8, 2024
@dwhswenson
Copy link
Member Author

This is ready for review and comment. Without review, I will merge this after at least 12 hours, no sooner than Thu 08 Aug 18:00 GMT (13:00 my local).

I'll follow that quickly with a PR to do a 0.3.1 patch release.

@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4a9d497) to head (b653f4c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         5422      5422           
=========================================
  Hits          5422      5422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bit surprised it passed tests without it

@dwhswenson
Copy link
Member Author

I think the issue here is that we don't do the all-optionals test when we do release testing. So we didn't trigger the code to import OpenMM (which is what this is about).

FWIW, we can also simplify the OpenMM code in there. Treating OpenMM with the rules of either SPEC0 or NEP29, we no longer need to support OpenMM 7.5.

@dwhswenson dwhswenson merged commit ded84ad into openpathsampling:main Aug 8, 2024
@dwhswenson dwhswenson deleted the add-compat-init branch August 8, 2024 16:42
@dwhswenson dwhswenson mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants