SPEC0/NEP29: Add Python 3.12, drop Python 3.9 #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 5420 5418 -2
=========================================
- Hits 5420 5418 -2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Also required fixing an error that apparently was silently passing in a misuse of mock until Python 3.12? (Or maybe based on older versions of mock?) This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Tue 11 Jun 01:00 GMT (Mon 10 Jun 20:00 my local). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SPEC0 and NEP29 currently recommend supporting Python versions 3.10, 3.11, and 3.12. Tests here hadn't started on 3.12 and still tested 3.9. This PR just changes the testing matrix.