Skip to content

Conversation

@dwhswenson
Copy link
Member

This is a better solution for #71 (should replace #72).

We really don't want all that junk in the contents output anyway. The purpose of that line to give the filename as part of the output, so let's just give the filename.

This is a better solution for openpathsampling#71 (should replace openpathsampling#72).

We really don't want all that junk in the `contents` output anyway.
The purpose of that line to give the filename as part of the output, so
let's just give the filename.
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 100.00% // Head: 99.96% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (dcda827) compared to base (600d361).
Patch coverage: 50.00% of modified lines in pull request are covered.

❗ Current head dcda827 differs from pull request most recent head d570f5b. Consider uploading reports for the commit d570f5b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #73      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files          110      110              
  Lines         5415     5418       +3     
===========================================
+ Hits          5415     5416       +1     
- Misses           0        2       +2     
Impacted Files Coverage Δ
paths_cli/tests/commands/test_contents.py 100.00% <ø> (ø)
paths_cli/commands/contents.py 96.92% <50.00%> (-3.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sroet
Copy link
Member

sroet commented Sep 6, 2022

This looks good to me. Please either add a test for the added error, or add a # pragma: no cover (no real preference from me)

@sroet sroet mentioned this pull request Sep 6, 2022
Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! codeclimate issue is not relevant for this temporary fix in my opinion. Feel free to merge

@dwhswenson dwhswenson merged commit b430d8b into openpathsampling:main Jan 7, 2023
@dwhswenson dwhswenson deleted the fix-contents-iss71 branch January 7, 2023 23:06
@dwhswenson dwhswenson mentioned this pull request May 5, 2024
@dwhswenson dwhswenson added the bug Something isn't working label May 5, 2024
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants