easy fix for test #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 5415 5412 -3
=========================================
- Hits 5415 5412 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dwhswenson
added a commit
to dwhswenson/openpathsampling-cli
that referenced
this pull request
Sep 6, 2022
This is a better solution for openpathsampling#71 (should replace openpathsampling#72). We really don't want all that junk in the `contents` output anyway. The purpose of that line to give the filename as part of the output, so let's just give the filename.
Member
Author
|
superseded by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is one of the possible solutions for #71
It is not the most elegant, but it makes the test pass.
I don't have the time to investigate this further and implement option 2 from this comment.
@dwhswenson feel free to close this one if you have a different preferred solution