-
Notifications
You must be signed in to change notification settings - Fork 3
Fill in information for compile docs
#67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
also commenting out TIS networks for now
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 2321 2314 -7
=========================================
- Hits 2321 2314 -7
Continue to review full report at Codecov.
|
'scheme' root compiler name, not movescheme
compile docscompile docs
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Mon 08 Nov 17:00 GMT (12:00 my local). CodeClimate had complaints, but they were all about similarity in code that is using a template (like plugins using the same keyword arguments, and only differing the strings that were reported.) Template similarity is not real similarity (since it's already refactored). |
sroet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about seemingly dropped functionality, leftover old code, and a typo, LGTM otherwise
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
sroet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR will clean up the
compilingsubpackage such that thegendocsscript creates complete and suitable documentation for the built-in plugins. This primarily involves adding descriptions and type information.