pylint/flake8: paths_cli.wizard
#66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main thing left is, I think, wizard.py
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 52 58 +6
Lines 2185 2293 +108
==========================================
+ Hits 2185 2293 +108
Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Fri 05 Nov 15:00 GMT (11:00 my local). |
sroet
approved these changes
Nov 4, 2021
Member
sroet
left a comment
sroet
left a comment
There was a problem hiding this comment.
One question about handling capitalization in one of the errors that I noticed, otherwise LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performs the pylint/flake8 cleanup for the
wizardsubpackage requested in #57. Mainly this involved removing some unused imports and unused code and adding a lot of docstrings.The Wizard API is still expected to be in a state of rapid flux (even after the v0.3 release) so some parameters that are likely to be removed are not always documented, and some methods that are likely to be removed are only partly documented. I also marked a few things as likely to change in the near future.
Code style exceptions to pylint/flake8 rules here: https://gist.github.com/dwhswenson/1361b849866af98e7f8e6599810670b2