Skip to content

Conversation

@dwhswenson
Copy link
Member

@dwhswenson dwhswenson commented Oct 29, 2021

This adds support for the !quit (or !q) command in the wizard to give the option to save objects created so far to a file. This has been the intent: !!quit is an immediate force-quit; !quit quits the wizard process early with the option to save.

This is one of the targets for v0.3 listed in #57:

  • Add support for catching the quit exception when the wizard is running

@dwhswenson dwhswenson mentioned this pull request Oct 29, 2021
18 tasks
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #63 (7568496) into main (2b6714b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #63   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         2113      2128   +15     
=========================================
+ Hits          2113      2128   +15     
Impacted Files Coverage Δ
paths_cli/wizard/wizard.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6714b...7568496. Read the comment docs.

@dwhswenson dwhswenson changed the title Wizard: !quit command should give option to save [WIP] Wizard: !quit command should give option to save Oct 29, 2021
@dwhswenson dwhswenson added the enhancement New feature or request label Oct 29, 2021
@dwhswenson dwhswenson marked this pull request as ready for review October 29, 2021 22:40
@dwhswenson dwhswenson changed the title [WIP] Wizard: !quit command should give option to save Wizard: !quit command should give option to save Oct 29, 2021
Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question about the final message, otherwise LGTM

@dwhswenson dwhswenson merged commit fd5dfb4 into openpathsampling:main Oct 31, 2021
@dwhswenson dwhswenson deleted the wizard-quit-save branch October 31, 2021 11:49
@dwhswenson dwhswenson mentioned this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants