Fix CodeCov action #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 1766 1766
=========================================
Hits 1766 1766 Continue to review full report at Codecov.
|
Member
Author
|
Looks like this fixed it! Will consider this ready to merge immediately after review, or if no review, after 12 hours from now (no earlier than Fri 08 Oct 19:00 GMT (15:00 my local)) -- after I get some sleep. |
sroet
approved these changes
Oct 8, 2021
Member
sroet
left a comment
sroet
left a comment
There was a problem hiding this comment.
LGTM, sorry for not catching that earlier
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like since #53 we haven't actually been successfully uploading coverage. I'll try to fix that here.