SimStore Support #29
Merged
SimStore Support #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Status: This is just waiting for a release of OPS with SimStore in it. When OPS 1.4 is released, this should be ready to merge. |
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 570 596 +26
=========================================
+ Hits 570 596 +26
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for reading/writing files using the new (experimental) SimStore storage subsystem. From a user's standpoint, the CLI will automatically use SimStore for filenames that end in
.dbor.sql, otherwise it uses netcdfplus.Note that this will have to be on hold until a few more SimStore PRs have been added to the OPS core code. In particular, we need to wait until SimStore has support for:
Also, note that this will only work with SimStore-native CVs; i.e., it doesn't manage the monkey-patching to allow old CVs based on netcdfplus to be used with SimStore.