Repository navigation
Record the decisions on surfaces, JDK-specific tests and imports - #230
Merged
Merged
Conversation
Every surface formats a whole file or a part of one, and for the same version and input every surface of an entry is to give the same result, with the command line as the reference for whole files. The record keeps the exceptions accepted for now and the alternatives turned down (#219).
Such tests skip themselves from inside today, in three ways, and pass for skipped on JDK 21. They are to carry their condition on the class, with case files in test-cases-java21/, test-cases-java25/ and so on, side by side; module imports from JDK 25.
The command line fixes imports after the layout, the Maven plugin and the Spotless steps before it, and the files differ where a removed import has a comment. Both stay until #224 decides, with what either order would change.
Their tests go by the version that previews them, as the module imports do, rather than by a condition on the value modifier: JDK 28's early-access builds, which CI runs, have it.
Each names the folders its JDK parses, and their ranges do not overlap, so every case runs once on any JDK.
…e-decision-records
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four architecture decision records, in
docs/decisions/, from the work on #219, #222 and #224. Documentation only; no code changes. Each record is Proposed, and becomes Accepted with this pull request.@EnabledForJreRangeon the class instead of assumptions inside the tests; case files intest-cases-java21/andtest-cases-java25/, side by side; module imports from JDK 25; value classes gated on thevaluemodifier.FormatterService.fixImports(IntelliJ plugin: optimize imports with open-java-format, not the IDE's own optimizer #222, after FormatterService.fixImports formats the whole file out of process #221). Includes why palantir-java-format dropped its optimizer in 2024.The changes that follow from them come in pull requests of their own.