|
17 | 17 | package com.palantir.javaformat.gradle; |
18 | 18 |
|
19 | 19 | import com.google.common.base.Preconditions; |
| 20 | +import com.google.common.collect.ImmutableMap; |
| 21 | +import com.google.common.io.Files; |
| 22 | +import groovy.util.Node; |
| 23 | +import groovy.util.XmlNodePrinter; |
| 24 | +import groovy.util.XmlParser; |
| 25 | +import java.io.BufferedWriter; |
20 | 26 | import java.io.File; |
| 27 | +import java.io.IOException; |
| 28 | +import java.io.PrintWriter; |
21 | 29 | import java.net.URI; |
| 30 | +import java.nio.charset.Charset; |
22 | 31 | import java.util.List; |
| 32 | +import java.util.function.Consumer; |
23 | 33 | import java.util.stream.Collectors; |
| 34 | +import javax.xml.parsers.ParserConfigurationException; |
24 | 35 | import org.gradle.api.Plugin; |
25 | 36 | import org.gradle.api.Project; |
26 | | -import org.gradle.api.Task; |
27 | 37 | import org.gradle.api.artifacts.Configuration; |
28 | | -import org.gradle.api.plugins.ExtensionAware; |
29 | | -import org.gradle.api.provider.Provider; |
30 | 38 | import org.gradle.plugins.ide.idea.model.IdeaModel; |
31 | | -import org.jetbrains.gradle.ext.TaskTriggersConfig; |
| 39 | +import org.xml.sax.SAXException; |
32 | 40 |
|
33 | 41 | public final class PalantirJavaFormatIdeaPlugin implements Plugin<Project> { |
34 | 42 |
|
@@ -60,25 +68,44 @@ private static void configureLegacyIdea(Project project, Configuration implConfi |
60 | 68 | } |
61 | 69 |
|
62 | 70 | private static void configureIntelliJImport(Project project, Configuration implConfiguration) { |
63 | | - project.getPluginManager().apply("org.jetbrains.gradle.plugin.idea-ext"); |
| 71 | + // Note: we tried using 'org.jetbrains.gradle.plugin.idea-ext' and afterSync triggers, but these are currently |
| 72 | + // very hard to manage as the tasks feel disconnected from the Sync operation, and you can't remove them once |
| 73 | + // you've added them. For that reason, we accept that we have to resolve this configuration at |
| 74 | + // configuration-time, but only do it when part of an IDEA import. |
| 75 | + if (!Boolean.getBoolean("idea.active")) { |
| 76 | + return; |
| 77 | + } |
| 78 | + project.getGradle().projectsEvaluated(gradle -> { |
| 79 | + List<URI> uris = implConfiguration.getFiles().stream().map(File::toURI).collect(Collectors.toList()); |
64 | 80 |
|
65 | | - Provider<? extends Task> configurePalantirJavaFormatXmlTask = project.getTasks() |
66 | | - .register("configurePalantirJavaFormatXml", ConfigurePalantirJavaFormatXml.class, task -> { |
67 | | - task.getImplConfiguration().set(implConfiguration); |
68 | | - }); |
| 81 | + createOrUpdateIdeaXmlFile(project.file(".idea/palantir-java-format.xml"), node -> |
| 82 | + ConfigureJavaFormatterXml.configureJavaFormat(node, uris)); |
| 83 | + createOrUpdateIdeaXmlFile(project.file(".idea/externalDependencies.xml"), node -> |
| 84 | + ConfigureJavaFormatterXml.configureExternalDependencies(node)); |
| 85 | + }); |
| 86 | + } |
69 | 87 |
|
70 | | - Provider<? extends Task> configurePalantirJavaFormatPluginDependencyXml = project.getTasks() |
71 | | - .register("configurePalantirJavaFormatPluginDependencyXml", ConfigureExternalDependenciesXml.class); |
| 88 | + private static void createOrUpdateIdeaXmlFile(File configurationFile, Consumer<Node> configure) { |
| 89 | + Node rootNode; |
| 90 | + if (configurationFile.isFile()) { |
| 91 | + try { |
| 92 | + rootNode = new XmlParser().parse(configurationFile); |
| 93 | + } catch (IOException | SAXException | ParserConfigurationException e) { |
| 94 | + throw new RuntimeException("Couldn't parse existing configuration file: " + configurationFile, e); |
| 95 | + } |
| 96 | + } else { |
| 97 | + rootNode = new Node(null, "project", ImmutableMap.of("version", "4")); |
| 98 | + } |
72 | 99 |
|
73 | | - Task palantirJavaFormatIntellij = project.getTasks().create("palantirJavaFormatIntellij", task -> { |
74 | | - task.setDescription("Configure IntelliJ directory-based repository after importing"); |
75 | | - task.setGroup(UpdateIntellijXmlTask.INTELLIJ_TASK_GROUP); |
76 | | - task.dependsOn(configurePalantirJavaFormatXmlTask, configurePalantirJavaFormatPluginDependencyXml); |
77 | | - }); |
| 100 | + configure.accept(rootNode); |
78 | 101 |
|
79 | | - ExtensionAware ideaProject = (ExtensionAware) project.getExtensions().getByType(IdeaModel.class).getProject(); |
80 | | - ExtensionAware settings = (ExtensionAware) ideaProject.getExtensions().getByName("settings"); |
81 | | - TaskTriggersConfig taskTriggers = settings.getExtensions().getByType(TaskTriggersConfig.class); |
82 | | - taskTriggers.beforeSync(palantirJavaFormatIntellij); |
| 102 | + try (BufferedWriter writer = Files.newWriter(configurationFile, Charset.defaultCharset()); |
| 103 | + PrintWriter printWriter = new PrintWriter(writer)) { |
| 104 | + XmlNodePrinter nodePrinter = new XmlNodePrinter(printWriter); |
| 105 | + nodePrinter.setPreserveWhitespace(true); |
| 106 | + nodePrinter.print(rootNode); |
| 107 | + } catch (IOException e) { |
| 108 | + throw new RuntimeException("Failed to write back to configuration file: " + configurationFile, e); |
| 109 | + } |
83 | 110 | } |
84 | 111 | } |
0 commit comments