Skip to content

introduce addtional http headers to OIDTokenRequest #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 26, 2023
Merged

introduce addtional http headers to OIDTokenRequest #770

merged 12 commits into from
Jun 26, 2023

Conversation

@break2k
Copy link
Contributor

@break2k break2k commented Apr 28, 2023 •
edited
Loading

Problem

My IDM requests an additional header from token requests we are currently unable to send with the AppAuth SDK.

Solution

Extend OIDTokenRequest similar to additionalParameters to use additionalHeaders.

Background

In order to fulfill our demands for quality control inside our corporation, we are adding some generated UUID for the session and the client that we can use for debugging.

Unfortunately, I am unable to share those internal documents.

@break2k
Copy link
Contributor Author

break2k commented May 19, 2023

How is this process here to get a review?

@mdmathias
Copy link
Collaborator

mdmathias commented May 19, 2023

@break2k The guide for contributions is here.

Would you mind adding more information about what your IDP needs? Links will be helpful. Please also add some explanation (doesn't need to be long) to add context and documentation for the future.

@break2k
Copy link
Contributor Author

break2k commented Jun 1, 2023

@break2k The guide for contributions is here.

Would you mind adding more information about what your IDP needs? Links will be helpful. Please also add some explanation (doesn't need to be long) to add context and documentation for the future.

I've updated the description of the pull request and also signed "Execute OpenID Foundation Contribution License Agreement".

mdmathias
mdmathias requested changes Jun 2, 2023
View reviewed changes
@break2k break2k requested a review from mdmathias June 8, 2023 07:16
mdmathias
mdmathias requested changes Jun 13, 2023
View reviewed changes
@break2k break2k requested a review from mdmathias June 14, 2023 06:43
mdmathias
mdmathias requested changes Jun 14, 2023
View reviewed changes
@DTalij
openid#770 move kRefreshTokenRequestException to OIDAuthState header;
46d16b9 
limit lines in test to 100 char limit;
use kRefreshTokenRequestException in tests;
@break2k break2k requested a review from mdmathias June 15, 2023 05:45
@mdmathias
Copy link
Collaborator

mdmathias commented Jun 21, 2023

@break2k looks like your PR has some test failures. Please fix! Thanks!

mdmathias
mdmathias requested changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@mdmathias mdmathias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test workflow run revealed that there were a few breakages that need to be fixed.

@break2k
Copy link
Contributor Author

break2k commented Jun 22, 2023

The test workflow run revealed that there were a few breakages that need to be fixed.

Has been resolved with the latest commit. 741d1e1

@break2k break2k requested a review from mdmathias June 22, 2023 08:31
@break2k
Copy link
Contributor Author

break2k commented Jun 26, 2023

@mdmathias Can you rerun the CI?

@mdmathias mdmathias merged commit 36c1df0 into openid:master Jun 26, 2023
@break2k break2k deleted the feature/token-request-with-additional-headers branch June 27, 2023 06:18
@break2k
Copy link
Contributor Author

break2k commented Jun 27, 2023

May I ask what the release process looks like? Can I assist in any way?

@mdmathias
Copy link
Collaborator

mdmathias commented Jun 27, 2023

I will need to make a minor release. That will require some changes to our Podspec, tagging a release, testing things, etc. I'm not sure when I will have time to do that. I will try my best to get to it soon. If you need your change urgently, then you could use AppAuth as a static library.

@break2k
Copy link
Contributor Author

break2k commented Jun 28, 2023

I will need to make a minor release. That will require some changes to our Podspec, tagging a release, testing things, etc. I'm not sure when I will have time to do that. I will try my best to get to it soon. If you need your change urgently, then you could use AppAuth as a static library.

Thank you for the elaboration. I would rather wait. Thanks for your patience and guidance in this PR.

mnkd added a commit to mnkd/GTMAppAuth that referenced this pull request Jul 12, 2023
@mnkd
fix: missing argument for parameter 'additionalHeaders' in call
1c38a12 
ref:

introduce addtional http headers to OIDTokenRequest
openid/AppAuth-iOS#770
@mnkd mnkd mentioned this pull request Jul 12, 2023
Draft
mnkd added a commit to mnkd/GoogleSignIn-iOS that referenced this pull request Jul 12, 2023
@mnkd
workaround: fix build error
6073699 
No visible @interface for 'OIDAuthorizationResponse' declares
the selector 'tokenExchangeRequestWithAdditionalParameters:'

ref:
openid/AppAuth-iOS#770
namanshergill added a commit to namanshergill/AppAuth-iOS that referenced this pull request Aug 19, 2023
@namanshergill
Revert "introduce addtional http headers to OIDTokenRequest (openid#770…
717bad2 
…)"

This reverts commit 36c1df0.
avidan-chen pushed a commit to avidan-chen/AppAuth-iOS that referenced this pull request Aug 20, 2023
@break2k @DTalij @avidan-chen
introduce addtional http headers to OIDTokenRequest (openid#770)
d2fcbe3 
Co-authored-by: Vitalij Dadaschjanz <vitalij.dadaschjanz@telekom.de>
GravityByte added a commit to GravityByte/AppAuth-iOS that referenced this pull request Oct 20, 2023
@GravityByte
fixed wrong variable for addtional http headers in OIDTokenRequest (o…
db6f1dd 
…penid#770)
GravityByte added a commit to GravityByte/AppAuth-iOS that referenced this pull request Oct 21, 2023
@GravityByte
added test for additional http headers in OIDTokenRequest (openid#770)
9bf6934
GravityByte added a commit to GravityByte/AppAuth-iOS that referenced this pull request Oct 24, 2023
@GravityByte
added one more test for additional http headers in OIDTokenRequest (o…
c80d7b4 
…penid#770)
mdmathias pushed a commit that referenced this pull request Oct 25, 2023
@GravityByte
fixed wrong variable for additional http headers in OIDTokenRequest (#…
aea7b8a 
…770) (#798)
HadesPTIT pushed a commit to HadesPTIT/AppAuth-iOS that referenced this pull request Nov 14, 2023
Revert "fixed wrong variable for additional http headers in OIDTokenR…
77fc81b 
…equest (openid#770) (openid#798)"

This reverts commit aea7b8a.
HadesPTIT pushed a commit to HadesPTIT/AppAuth-iOS that referenced this pull request Nov 14, 2023
Revert "introduce addtional http headers to OIDTokenRequest (openid#770…
3ad2abc 
…)"

This reverts commit 36c1df0.
@mdmathias mdmathias mentioned this pull request Mar 9, 2024
Merged
@wojteklembryk wojteklembryk mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathias mdmathias mdmathias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@break2k @mdmathias @DTalij