feat: use chown during copy to reduce image size and build time#58
Merged
alexellis merged 1 commit intoopenfaas:masterfrom Oct 4, 2022
Merged
Conversation
3 tasks
Member
|
Sorry I missed this or let it fall off the radar. Could you rebase it onto HEAD? |
Using the `--chown` flag during `COPY` is much faster than running `chown -R`. It also removes a layer from the image, resulting in faster and smaller builds. Resolves openfaas#55 Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
c53ed3b to
d654526
Compare
Member
Author
|
@alexellis done |
Member
|
Looks good, thank you! I'll cut a release so that people can pin this revision if they want to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
--chownflag duringCOPYis much faster than runningchown -R. It also removes a layer from the image, resulting in fasterand smaller builds.
Motivation and Context
design/approvedlabelResolves #55
How Has This Been Tested?
Types of changes
Checklist:
git commit -s