Make TEST_ENABLED conditional syntax POSIX friendly#54
Merged
alexellis merged 1 commit intoopenfaas:masterfrom May 3, 2022
Merged
Make TEST_ENABLED conditional syntax POSIX friendly#54alexellis merged 1 commit intoopenfaas:masterfrom
alexellis merged 1 commit intoopenfaas:masterfrom
Conversation
Signed-off-by: Bob Schmitz III <schmitzr1984@gmail.com>
LucasRoesler
approved these changes
Apr 27, 2022
Member
|
@alexellis this is 👍 but i can't merge it myself, I think you are the only one that can. |
Member
|
Thanks for the PR and review. A good time to get eyes on PRs and requests like this would be at our weekly community call, feel free to see the pinned issue at: https://github.com/openfaas/faas/issues Alex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bob Schmitz III schmitzr1984@gmail.com
Description
TEST_ENABLEDconditional syntax to be POSIX friendly.Motivation and Context
This fixes a syntax error occurring in Debian based image templates which uses dash as the default shell.
design/approvedlabelCloses #53
How Has This Been Tested?
python:3.7-alpineandpython:3.7-slim-buster(see https://gist.github.com/rgschmitz1/1cc3f375e582433dc80191b87d2e103e for detailed log).docker buildcommand for both base images.faas-cli version):docker version(e.g. Docker 17.0.05 ):Types of changes
Checklist:
git commit -s