fix: tox config file as in sub directory correcting WORKDIR#46
Merged
alexellis merged 1 commit intoopenfaas:masterfrom Apr 6, 2021
Merged
fix: tox config file as in sub directory correcting WORKDIR#46alexellis merged 1 commit intoopenfaas:masterfrom
alexellis merged 1 commit intoopenfaas:masterfrom
Conversation
Signed-off-by: saikiran <neo2603@gmail.com>
LucasRoesler
approved these changes
Apr 1, 2021
Member
LucasRoesler
left a comment
There was a problem hiding this comment.
Looks good and the templates are now in sync
Member
|
@alexellis this is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: saikiran neo2603@gmail.com
Tox config is not in the directory from where tox command is executed, moved WORKDIR change which was happening before test to after , this ensures tox executes from inside the function folder.
Description
moved WORKDIR command after the test execution , modified copy and chown command to execute properly from new WORKDIR
Motivation and Context
helps fix issue #44
design/approvedlabelHow Has This Been Tested?
tested with creating new function and executing faas build.
Types of changes
Checklist:
git commit -s