Remove gevent and use waitress in all templates#33
Conversation
**What** - Update all templates to use waitress instead of gevent. This avoids the need to install things like gcc, make, or libffi-dev into the alpine images. The user can still install these via the ADDITIONAL_PACKAGES build arg, if they are needed. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
martindekov
left a comment
martindekov
left a comment
There was a problem hiding this comment.
Tested with function with the python3-flask:
- Successfully built
- Successfully ran:
2020/05/01 22:06:15 Started logging stderr from function.
2020/05/01 22:06:15 Started logging stdout from function.
2020/05/01 22:06:15 OperationalMode: http
2020/05/01 22:06:15 Timeouts: read: 10s, write: 10s hard: 10s.
2020/05/01 22:06:15 Listening on port: 8080
2020/05/01 22:06:15 Writing lock-file to: /tmp/.lock
2020/05/01 22:06:15 Metrics listening on port: 8081
2020/05/01 22:09:41 POST / - 200 OK - ContentLength: 17
LGTM
martindekov
left a comment
martindekov
left a comment
There was a problem hiding this comment.
Can we add Closes #32 in the PR description so we close the Issue on merge?
|
Hi @LucasRoesler, I can see why we changed from gevent in the Alpine Linux variants, but was gevent needing a compilation in Debian? |
yes gevent is going to require that compile stage in any installation, unless you are installing some precompiled wheel/binary from something like conda or apt-get. The same is true for Pandas, NumPy, Pillow (i think), lxml is another common dependency that i think requires development headers (it is used in xml/html parsing, e.g. Beautifulsoup uses it) |
3 participants
What
the need to install things like gcc, make, or libffi-dev into the
alpine images. The user can still install these via the
ADDITIONAL_PACKAGES build arg, if they are needed.
Signed-off-by: Lucas Roesler roesler.lucas@gmail.com