Create debian templates for the python 3 flask templates.#30
Merged
Create debian templates for the python 3 flask templates.#30
Conversation
The current python3-flask templates use the Alpine base python image. Precompiled wheels for many important python libraries are not available for Alpine, but are easily available for Debian. Using Debian makes it much simpler and easier to use python packages like Numpy or Pillow. Updated existing Alpine Docker files to include comments. The template yaml file for the python-http-debian was modified to remove unneeded libraries. Both docker files were changed to force python 3.7. Gevent 1.4 is incompatible with Python 3.8, and the rest of the docker files use python 3.7. This has been tested with a bare bones basic function and builds, runs, and executes properly. Change listening address for WSGI server. Update the listening address for the WSGI server to use 0.0.0.0 instead of ''. This should resolve errors about Address family not supported by protocol (Python OSError Errno 97. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com> Signed-off-by: Jeff Lowrey <jefferson.lowrey@mantech.com>
Member
Author
|
@LucasRoesler @viveksyngh @Jeff-Lowrey FYI This commit squashes all the WIP commits and reworking down into one concise commit and message. |
Member
Author
|
@Jeff-Lowrey can you now send a PR to the template store for the new templates? https://github.com/openfaas/store/blob/master/templates.json |
Member
Author
|
The README also needs to be updated as per:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current python3-flask templates use the Alpine base python image.
Precompiled wheels for many important python libraries are not available
for Alpine, but are easily available for Debian. Using Debian makes it
much simpler and easier to use python packages like Numpy or Pillow.
Updated existing Alpine Docker files to include comments.
The template yaml file for the python-http-debian was modified to remove
unneeded libraries.
Both docker files were changed to force python 3.7. Gevent 1.4 is
incompatible with Python 3.8, and the rest of the docker files use
python 3.7.
This has been tested with a bare bones basic function and builds,
runs, and executes properly.
Change listening address for WSGI server.
Update the listening address for the WSGI server to use 0.0.0.0
instead of ''. This should resolve errors about Address family
not supported by protocol (Python OSError Errno 97.
Closes #26
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com
Signed-off-by: Jeff Lowrey jefferson.lowrey@mantech.com