Set default value for HOSTNAME for python3-http templates#27
Merged
alexellis merged 1 commit intoopenfaas:masterfrom Mar 30, 2020
Merged
Set default value for HOSTNAME for python3-http templates#27alexellis merged 1 commit intoopenfaas:masterfrom
alexellis merged 1 commit intoopenfaas:masterfrom
Conversation
This will avoid raising KeyError exceptions when trying to fetch the value of the HOSTNAME env variable on faasd. Signed-off-by: Mehdi Yedes <mehdi.yedes@gmail.com>
Member
|
Thank you @mehyedes Just to note for anyone who lands here, this issue was seen with faasd and when running the template directly on MacOS outside of a container where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HOSTNAMEenvironment variable is not available in faasd, which makes any function using thepython3-httptemplate fail with the following error with aKeyErrorexception.Setting a default value should fix this issue
Signed-off-by: Mehdi Yedes mehdi.yedes@gmail.com