Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openfaas/python-flask-template
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openfaas/python-flask-template
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: drain_python3_http
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on May 25, 2023

  1. Drain connections for python3-http 

    When used with OpenFaaS Standard/Enterprise, the python3-http
template's handler will now ignore SIGTERM allowing the
watchdog and Kubernetes to handle the shutdown.

When there are ongoing requests, these will be processed
before exiting.

When there are no ongoing requests, the function will
exit immediately.

Tested with OpenFaaS Standard a long running sleep function which
went into a Terminating status. The function continued to
execute its sleep for the whole duration, whilst the new
replica came online and was ready in the meantime.

This is the same approach tested for the golang-http templates.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    @alexellis
    alexellis committed May 25, 2023
    Configuration menu
    Copy the full SHA
    b1dd32b View commit details
    Browse the repository at this point in the history
Loading