OBPIH-7732 E-Request UI improvements#5911
Conversation
Change delete button to red trashcan
github-actions
Bot
added
type: feature
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5911 +/- ##
=============================================
+ Coverage 9.93% 10.51% +0.57%
- Complexity 1395 1598 +203
=============================================
Files 745 801 +56
Lines 46466 47462 +996
Branches 11045 11222 +177
=============================================
+ Hits 4617 4990 +373
- Misses 41114 41683 +569
- Partials 735 789 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awalkowiak
requested review from
SebastianLib,
alannadolny,
awalkowiak and
kchelstowski
| }, | ||
| }; | ||
|
|
||
| const DeleteIcon = () => <RiDeleteBinLine />; |
There was a problem hiding this comment.
Why is it a function? ButtonField accepts buttonLabel and checks if the prop is a string. If not, it should render the component, so I believe it should work with just RiDeleteBinLabel, but I can be wrong
There was a problem hiding this comment.
This was the only way I found that displayed the icon. I'm open to suggestions how to do it better.
| quantityRequested: { | ||
| ...FIELDS.quantityRequested, | ||
| flexWidth: '2.5', | ||
| fixedWidth: '10ch', |
There was a problem hiding this comment.
Why "ch"? I didn't see that before anywhere.
There was a problem hiding this comment.
Unit ch is relative to the width of the "0" (zero). How should it be done better?
There was a problem hiding this comment.
How does the "ch" work when the screen size changes? We support everything above 1368px. If it works fine, I am ok with that.
| comments: { | ||
| ...FIELDS.comments, | ||
| flexWidth: '6', | ||
| }, |
There was a problem hiding this comment.
Can't you change the flexWidth in the FIELDS definition?
apply pr comments
| style: { | ||
| color: '#dc3545', | ||
| border: 'none', | ||
| 'font-size': '1rem', | ||
| }, |
There was a problem hiding this comment.
If possible, let's avoid inline styles and keep styles inside CSS classes. Also, please use CSS variables for colors instead of hardcoded values. Color variables should be defined in colors.scss, and use for example:
color: var(--orange-500);
avoid inline styles
remove unnecessary function
3 participants
✨ Description of Change
Link to GitHub issue or Jira ticket:
https://pihemr.atlassian.net/browse/OBPIH-7732
Description:
I made changes described in the ticket in the Add Items page from Inbound -> Create Stock Request.
📷 Screenshots & Recordings (optional)