OBPIH-7501 Allow update recipient and ship dates via PO import when source inactive#5719
Conversation
alannadolny
requested review from
SebastianLib,
awalkowiak,
ewaterman and
kchelstowski
github-actions
Bot
added
type: bug
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5719 +/- ##
============================================
+ Coverage 9.12% 9.84% +0.71%
- Complexity 1170 1376 +206
============================================
Files 701 732 +31
Lines 45281 46137 +856
Branches 10851 11014 +163
============================================
+ Hits 4131 4541 +410
- Misses 40497 40891 +394
- Partials 653 705 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| } | ||
| if (!productSource.active) { | ||
| throw new ProductException("Product source ${sourceCode} for product ${productCode} is inactive") | ||
| } |
There was a problem hiding this comment.
Don't you actually allow to update all fields by this change? Wasn't it only supposed to allow to update recipient and ship dates when the source is inactive?
There was a problem hiding this comment.
It's hard to say what the desired behavior is. I need to ask Kelsey :/
There was a problem hiding this comment.
after yesterdays standup, I pushed a fix that prevents import when there are new order items with disabled product source, but I allow to modify existing lines with disabled sources.
cc @ewaterman
… during order creation
3 participants
No description provided.