Skip to content

Conversation

@codebutler
Copy link
Contributor

fixes #958

@dbanty dbanty enabled auto-merge February 20, 2024 01:03
Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A perfect PR 🙇

@dbanty dbanty disabled auto-merge February 20, 2024 01:05
@dbanty dbanty changed the title fix: bad code generated for nested unions bad code generated for nested unions Feb 20, 2024
@dbanty dbanty enabled auto-merge February 20, 2024 01:05
@dbanty dbanty added this pull request to the merge queue Feb 20, 2024
Merged via the queue into openapi-generators:main with commit 7eb4093 Feb 20, 2024
dbanty added a commit that referenced this pull request Feb 20, 2024
This PR was created by Knope. Merging it will create a new release

### Fixes

#### Remove spurious field_dict.update({}) for types without properties
(#969)

#### Fix invalid type check for nested unions

Nested union types (unions of unions) were generating `isinstance()`
checks that were not valid (at least for Python 3.9).

Thanks to @codebutler for PR #959 which fixes #958 and #967.

Co-authored-by: GitHub <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid code generated for nullable discriminated union

2 participants