Nullable array support fixes #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2024
dbanty
previously approved these changes
Jan 4, 2024
Collaborator
dbanty
left a comment
dbanty
left a comment
There was a problem hiding this comment.
Thanks for this fix! It made me think about what intial_value was even doing and why all those extra type checks were in there. Turns out, the union property checks for Unset, so there's never a reason to have the inner property also check. Which means there's no reason for initial_value at all. This greatly simplified the generated code!
dbanty
approved these changes
Jan 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #928 with two simple fixes:
get_type_string()toListPropertybased on the definition inModelProperty, since both arrays and objects are JSON-serialized in multipart mode.UNSETis the default (initial) value when constructing a list property.