Skip to content

Bump isort from 4.3.21 to 5.0.5 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbanty merged 4 commits into from
Jul 8, 2020
Merged

Bump isort from 4.3.21 to 5.0.5 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d44c7f9
Bump isort from 4.3.21 to 5.0.5
dependabot-preview[bot] Jul 8, 2020
7e27483
Update isort commands to 5.x and run to apply new sorting
dbanty Jul 8, 2020
f6227a6
Update internal usage of isort and Poetry lock
dbanty Jul 8, 2020
5cffe6a
Blacken code
dbanty Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
command: |
mkdir -p test-reports/safety test-reports/mypy test-reports/pytest
poetry run black . --check
poetry run isort
poetry run isort . --check
poetry run safety check --json > test-reports/safety/results.json
poetry run mypy openapi_python_client --junit-xml=test-reports/mypy/results.xml
poetry run pytest --junitxml=test-reports/pytest/results.xml --cov=openapi_python_client tests
Expand Down
6 changes: 1 addition & 5 deletions openapi_python_client/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,7 @@ def update(self) -> None:

def _reformat(self) -> None:
subprocess.run(
"isort --recursive --apply",
cwd=self.project_dir,
shell=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
"isort .", cwd=self.project_dir, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
)
subprocess.run("black .", cwd=self.project_dir, shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

Expand Down
Loading